Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): disable x-nuxt-no-ssr header by default #20024

Merged
merged 9 commits into from
Apr 3, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Apr 1, 2023

πŸ”— Linked issue

resolves #15667

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We have an undocumented header for disabling SSR responses, x-nuxt-no-ssr. I think it would be better not to have this enabled by default as it allows third-parties to control the behaviour of the Nuxt renderer.

I think we can consider this a non-breaking change if clearly signposted in release notes.

πŸ‘‰ Migration

If you were using the x-nuxt-no-ssr flag, you can turn on the previous behaviour with:

export default defineNuxtConfig({
  experimental: {
    respectNoSSRHeader: true
  }
})

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 1, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general to make ssr behavior more predictable

@danielroe danielroe requested a review from pi0 April 3, 2023 09:36
@danielroe danielroe changed the title fix(nuxt): allow disabling x-nuxt-no-ssr header fix(nuxt): disable x-nuxt-no-ssr header by default Apr 3, 2023
@danielroe danielroe merged commit c660b39 into main Apr 3, 2023
@danielroe danielroe deleted the fix/nuxt-no-ssr-header branch April 3, 2023 10:39
@danielroe danielroe mentioned this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opt-in (or out) of "x-nuxt-no-ssr" HTTP header feature
3 participants