Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): set different cache dirs for client/server #20276

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Apr 14, 2023

πŸ”— Linked issue

#20273

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

A custom plugin we wrote to achieve this same task was silently rendered ineffective (owing to @ts-ignore, which I quietly hate) in a previous vite upgrade. We can now use the top-level cacheDir to achieve the same result. Though I'm not aware of any issues at the moment, this should prevent sharing optimised dependencies between server + client.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 14, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe merged commit b602b66 into main Apr 14, 2023
@danielroe danielroe deleted the fix/vite-cache-dir branch April 14, 2023 12:25
This was referenced Apr 19, 2023
This was referenced Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants