Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nuxt): rework and use isJS and isVue utilities consistently #20344

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Apr 18, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This updates the isVueTemplate helper to be useable for more of the transforms and detect script/template/script setup/style blocks. It also refactors our plugins to use it so any issues can be addressed in a central place and transformInclude will be more readable.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 18, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

antfu
antfu previously approved these changes Apr 18, 2023
@danielroe danielroe changed the title fix: exclude script blocks from isVueTemplate refactor(nuxt): rework and use isJS and isVue utilities consistently Apr 18, 2023
@danielroe danielroe marked this pull request as ready for review April 18, 2023 12:54
@danielroe danielroe requested a review from antfu April 18, 2023 12:54
@danielroe danielroe merged commit c7be5b4 into main Apr 19, 2023
@danielroe danielroe deleted the fix/vue-sourcemaps branch April 19, 2023 18:17
This was referenced Apr 19, 2023
This was referenced Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants