Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-utils): import jest.fn from @jest/globals #20360

Merged
merged 6 commits into from
Apr 19, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This uses @jest/globals to import jest.fn from: https://jestjs.io/docs/api.

We might consider not adding as a dep given how heavy it is. wdyt @antfu?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from antfu April 18, 2023 14:57
@danielroe danielroe self-assigned this Apr 18, 2023
@danielroe danielroe changed the title fix(test-utils): set jest.fn from correct place fix(test-utils): import jest.fn from @jest/globals Apr 18, 2023
@codesandbox
Copy link

codesandbox bot commented Apr 18, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@antfu
Copy link
Member

antfu commented Apr 18, 2023

Looks ok. Do we need to explicitly external it?

@danielroe
Copy link
Member Author

I've added to (optional) peerDeps - but again, happy if you have a different suggestion!

@danielroe danielroe merged commit 526852c into main Apr 19, 2023
@danielroe danielroe deleted the fix/jest-setup branch April 19, 2023 18:05
This was referenced Apr 19, 2023
This was referenced Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants