Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxi): add back default baseUrl in tsconfig.json #21632

Merged
merged 5 commits into from Jun 19, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 19, 2023

πŸ”— Linked issue

follow up on #21070, #21081

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR partially reverts the change in #21081, defering the change to typescript.compilerOptions.baseUrl until Nuxt 3.7, as we have tooling (notably our internal eslint-config) that currently relies on baseUrl being set.

It does aim to be compatible with removing baseUrl, for users who want to opt in early, by using absolute paths for aliases.

It should also give us longer to confirm that the normalisation changes (converting inferred relative paths to explicit ones) continue to work for a non-breaking upgrade path.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe marked this pull request as ready for review June 19, 2023 11:48
@danielroe danielroe requested a review from antfu June 19, 2023 16:19
@danielroe danielroe changed the title fix(nuxi): remove default baseUrl fix(nuxi): add bacl default baseUrl Jun 19, 2023
@danielroe danielroe changed the title fix(nuxi): add bacl default baseUrl fix(nuxi): add back default baseUrl Jun 19, 2023
@danielroe danielroe changed the title fix(nuxi): add back default baseUrl fix(nuxi): add back default baseUrl in tsconfig.json Jun 19, 2023
@danielroe danielroe merged commit bb4ed5e into main Jun 19, 2023
29 checks passed
@danielroe danielroe deleted the fix/base-url-default branch June 19, 2023 22:29
@github-actions github-actions bot mentioned this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant