Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): remove baseUrl and use relative paths in tsconfig #22410

Merged
merged 5 commits into from Aug 1, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #21827

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This finishes work in #21081 and #21632 to remove baseUrl and normalise all absolute paths in include/exclude/paths to relative urls.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@daniluk4000
Copy link
Contributor

Nice!

@danielroe danielroe marked this pull request as ready for review July 31, 2023 12:36
@danielroe
Copy link
Member Author

/ecosystem-ci run

@nuxt-ecosystem-ci

This comment was marked as duplicate.

@danielroe
Copy link
Member Author

/ecosystem-ci run

@nuxt-ecosystem-ci
Copy link

nuxt-ecosystem-ci bot commented Jul 31, 2023

πŸ“ Ran ecosystem CI: Open

suite result
starter βœ… success
content βœ… success
image ❌ failure
pinia βœ… success
examples βœ… success
bridge ❌ failure
nuxt-vitest βœ… success
vite-pwa βœ… success
docus βœ… success
og-image βœ… success
elk ❌ failure
devtools βœ… success
module-builder βœ… success
sanity-module βœ… success
i18n-module ❌ failure

@danielroe
Copy link
Member Author

/ecosystem-ci run image bridge

@danielroe danielroe requested review from pi0 and antfu July 31, 2023 14:49
@danielroe
Copy link
Member Author

/ecosystem-ci run image

@danielroe
Copy link
Member Author

/ecosystem-ci run bridge

@nuxt-ecosystem-ci
Copy link

nuxt-ecosystem-ci bot commented Jul 31, 2023

πŸ“ Ran ecosystem CI: Open

suite result
image βœ… success

@nuxt-ecosystem-ci
Copy link

nuxt-ecosystem-ci bot commented Jul 31, 2023

πŸ“ Ran ecosystem CI: Open

suite result
bridge ❌ failure

@danielroe
Copy link
Member Author

danielroe commented Jul 31, 2023

Only elk failure is related to this PR

@danielroe
Copy link
Member Author

/ecosystem-ci run elk

@nuxt-ecosystem-ci
Copy link

nuxt-ecosystem-ci bot commented Jul 31, 2023

πŸ“ Ran ecosystem CI: Open

suite result
elk ❌ failure

@danielroe
Copy link
Member Author

ok, now Elk failure is normal and unrelated to this PR πŸ˜†

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE types are broken after upgrade to 3.6.0 when using Docker (and WSL Webstorm)
4 participants