Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit,nuxi): add writeTypes utility #22385

Merged
merged 7 commits into from Jul 31, 2023
Merged

feat(kit,nuxi): add writeTypes utility #22385

merged 7 commits into from Jul 31, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jul 29, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This moves the creation/curation of core nuxt tsconfig.json out of nuxi and into @nuxt/kit. This will be important as we continue development on https://github.com/nuxt/cli to ensure we keep types in sync across the cli projects. Also, tsconfig changes are more tied to nuxt version, not nuxi version.

At the moment this PR uses kit implementation in preference if it exists, as well as inlining the current implementation from kit. We could add a deprecation and suggest updating kit/nuxt version if it's missing writeTypes, and then later remove this. Thoughts @pi0?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe requested a review from antfu July 30, 2023 15:40
@danielroe danielroe added this to the 3.7 milestone Jul 30, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’―

@danielroe danielroe merged commit 38d2bb7 into main Jul 31, 2023
30 checks passed
@danielroe danielroe deleted the refactor/write-types branch July 31, 2023 08:42
@github-actions github-actions bot mentioned this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants