Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): decrement hydration count when rendering no route #23476

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #23468

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

An edge case - when we have no nested route to render, on initial hydration we increment but don't decrement hydration count. This fixes that issue.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Sep 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit 96d9d56 into main Oct 1, 2023
33 checks passed
@danielroe danielroe deleted the fix/hydrate-null-routes branch October 1, 2023 15:22
@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuxtPage within a page without nested pages causes vuetify-theme-stylesheet not to be injected
2 participants