Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): fix addServerImportsDir implementation #24000

Merged
merged 3 commits into from Oct 31, 2023
Merged

fix(kit): fix addServerImportsDir implementation #24000

merged 3 commits into from Oct 31, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The implementation of addServerImportsDir wasn't registering auto-imports but registering them to be scanned for API routes.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from Atinux October 28, 2023 06:16
@danielroe danielroe self-assigned this Oct 28, 2023
@stackblitz
Copy link

stackblitz bot commented Oct 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio
Copy link

nuxt-studio bot commented Oct 28, 2023

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview 8399f9a

@danielroe danielroe mentioned this pull request Oct 28, 2023
Merged
8 tasks
@danielroe danielroe merged commit ebb5767 into main Oct 31, 2023
35 checks passed
@danielroe danielroe deleted the fix/server-imports-dir branch October 31, 2023 13:16
@github-actions github-actions bot mentioned this pull request Oct 31, 2023
Merged
manniL pushed a commit that referenced this pull request Dec 11, 2023
@danielroe @manniL
fix(kit): fix addServerImportsDir implementation (#24000)
546d580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trandaison trandaison trandaison left review comments

@Atinux Atinux Atinux approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug kit 🔨 p3-minor-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielroe @Atinux @trandaison