Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kit): add new addServerScanDir composable #24001

Merged
merged 8 commits into from Dec 14, 2023
Merged

feat(kit): add new addServerScanDir composable #24001

merged 8 commits into from Dec 14, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Oct 28, 2023 •
edited

🔗 Linked issue

#24000

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This migrates previous implementation of addServerImportsDir to addServerScanDir.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Oct 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio
Copy link

nuxt-studio bot commented Oct 28, 2023

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview affbcb4

@danielroe danielroe added this to the 3.9 milestone Oct 28, 2023
pi0
pi0 reviewed Oct 28, 2023
View reviewed changes
docs/3.api/5.kit/11.nitro.md Outdated Show resolved Hide resolved
@danielroe danielroe changed the title feat(kit): add new addServerRoutesDir composable feat(kit): add new addServerScanDir composable Dec 14, 2023
@danielroe danielroe requested a review from pi0 December 14, 2023 11:22
pi0
pi0 reviewed Dec 14, 2023
View reviewed changes
docs/3.api/5.kit/11.nitro.md Outdated Show resolved Hide resolved
docs/3.api/5.kit/11.nitro.md Outdated Show resolved Hide resolved
pi0
pi0 reviewed Dec 14, 2023
View reviewed changes
packages/kit/src/nitro.ts Outdated Show resolved Hide resolved
@danielroe @pi0
Update docs/3.api/5.kit/11.nitro.md
a972eac 
Co-authored-by: Pooya Parsa <pyapar@gmail.com>
@Atinux
Copy link
Member

Atinux commented Dec 14, 2023

This migrates previous implementation of addServerImportsDir to addServerScanDir.

Is it related? For me addServerImportsDir is useful to add another directory for auto-imports (like server/services/ for example)

@danielroe
Copy link
Member Author

@Atinux The issue was that this utility was originally added under the somewhat misleading name addServerImportsDir. This PR was created to port that code to a better-named utility.

@danielroe danielroe merged commit c5ff169 into main Dec 14, 2023
35 of 36 checks passed
@danielroe danielroe deleted the feat/add-server-routes branch December 14, 2023 17:11
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atinux Atinux Atinux approved these changes

@logotip4ik logotip4ik logotip4ik left review comments

@pi0 pi0 pi0 approved these changes

@huang-julien huang-julien Awaiting requested review from huang-julien

Assignees
No one assigned
Labels
3.x enhancement kit 🍰 p2-nice-to-have
Projects
None yet
Milestone
3.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danielroe @Atinux @pi0 @logotip4ik @huang-julien