New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): remove experimental reactivityTransform
(vue 3.4)
#24477
Conversation
Run & review this pull request in StackBlitz Codeflow. |
This is great - thank you β€οΈ Would you rename the component or disable the lint rule? |
@danielroe we also need to remove the reactivity transform from the experimental config, otherwise types will also probably break in the ecosystem ci. Let's do this in this PR. This is going to be a breaking change for users using reactiveTransform |
We can add migration steps in the release. We'll also need to update the docs |
Couldn't we install the macro if the option is set and warn the user? That way, it could reduce breakage and apps would still work, right? π€ |
Vue Macros has Nuxt Integration, I guess we could mention it in the migration note? https://vue-macros.dev/guide/nuxt-integration.html |
β Live Preview ready!
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #24477 +/- ##
=======================================
Coverage ? 58.65%
=======================================
Files ? 5
Lines ? 861
Branches ? 46
=======================================
Hits ? 505
Misses ? 356
Partials ? 0 β View full report in Codecov by Sentry. |
|
reactivityTransform
(vue 3.4)
π Linked issue
https://github.com/vuejs/ecosystem-ci/actions/runs/7001986839/job/19044928365 fix the nuxt ci
β Type of change
Hi π this PR removes the reactivity transform from SugarCounter within our basic test fixtures since vue 3.4 removes it.
π Description
π Checklist