Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): remove experimental reactivityTransform (vue 3.4) #24477

Merged
merged 5 commits into from Nov 27, 2023

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Nov 27, 2023

πŸ”— Linked issue

https://github.com/vuejs/ecosystem-ci/actions/runs/7001986839/job/19044928365 fix the nuxt ci

❓ Type of change

Hi πŸ‘‹ this PR removes the reactivity transform from SugarCounter within our basic test fixtures since vue 3.4 removes it.

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Nov 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe
Copy link
Member

This is great - thank you ❀️

Would you rename the component or disable the lint rule?

@huang-julien huang-julien marked this pull request as draft November 27, 2023 10:29
@huang-julien
Copy link
Member Author

@danielroe we also need to remove the reactivity transform from the experimental config, otherwise types will also probably break in the ecosystem ci. Let's do this in this PR.

This is going to be a breaking change for users using reactiveTransform

@huang-julien huang-julien changed the title test: refactor SugarCounter to Counter refactor(nuxt)!: remove reactivityTransform for vue 3.4 Nov 27, 2023
@danielroe
Copy link
Member

We can add migration steps in the release. We'll also need to update the docs

@manniL
Copy link
Member

manniL commented Nov 27, 2023

Couldn't we install the macro if the option is set and warn the user? That way, it could reduce breakage and apps would still work, right? πŸ€”

@antfu
Copy link
Member

antfu commented Nov 27, 2023

Vue Macros has Nuxt Integration, I guess we could mention it in the migration note? https://vue-macros.dev/guide/nuxt-integration.html

Copy link

nuxt-studio bot commented Nov 27, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio β†—οΈŽ View Live Preview 2d480e4

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

❗ No coverage uploaded for pull request base (main@1012dc0). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24477   +/-   ##
=======================================
  Coverage        ?   58.65%           
=======================================
  Files           ?        5           
  Lines           ?      861           
  Branches        ?       46           
=======================================
  Hits            ?      505           
  Misses          ?      356           
  Partials        ?        0           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@huang-julien
Copy link
Member Author

huang-julien commented Nov 27, 2023

Note that this feature has been marked as deprecated in Vue 3.3 and is planned to be removed from core in Vue 3.4. this was already warned in the JSDoc.
Should we add the installation of vue-macro in another PR ?

@huang-julien huang-julien marked this pull request as ready for review November 27, 2023 22:18
@danielroe danielroe changed the title refactor(nuxt)!: remove reactivityTransform for vue 3.4 fix(nuxt): remove experimental reactivityTransform (vue 3.4) Nov 27, 2023
@danielroe danielroe merged commit 0eb9caf into main Nov 27, 2023
35 checks passed
@danielroe danielroe deleted the test/ci-ecosystem-vue3.4 branch November 27, 2023 23:02
@github-actions github-actions bot mentioned this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants