Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vue-app): add group for ssr logs #5770

Merged
merged 2 commits into from
May 21, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented May 20, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

With this pr, the log will be like:
image

It's just a proposal, please feel free to leave comment for necessity, style...

@pi0 If consola has any plan or possibility to support group ?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from Atinux and pi0 May 20, 2019 13:09
@codecov-io
Copy link

Codecov Report

Merging #5770 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5770      +/-   ##
==========================================
+ Coverage   95.67%   95.71%   +0.03%     
==========================================
  Files          82       82              
  Lines        2660     2660              
  Branches      682      682              
==========================================
+ Hits         2545     2546       +1     
+ Misses         97       96       -1     
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.71% <ø> (ø) ⬆️
#unit 92.66% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 94.3% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7084b3a...b081780. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #5770 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5770      +/-   ##
==========================================
+ Coverage   95.64%   95.67%   +0.03%     
==========================================
  Files          82       82              
  Lines        2661     2661              
  Branches      683      683              
==========================================
+ Hits         2545     2546       +1     
+ Misses         97       96       -1     
  Partials       19       19
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.69% <ø> (ø) ⬆️
#unit 92.63% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 94.3% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106836f...892c95d. Read the comment docs.

@pi0
Copy link
Member

pi0 commented May 20, 2019

@clarkdo I may consider supporting group as same functionality is required for time measurement as well. But current change looks good to me

@clarkdo clarkdo marked this pull request as ready for review May 20, 2019 14:53
@pi0 pi0 mentioned this pull request May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants