New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: prepare for external typescript support #5854
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5854 +/- ##
==========================================
- Coverage 95.72% 95.68% -0.04%
==========================================
Files 82 82
Lines 2690 2689 -1
Branches 690 690
==========================================
- Hits 2575 2573 -2
- Misses 97 98 +1
Partials 18 18
Continue to review full report at Codecov.
|
@pi0 Should we rename https://github.com/nuxt/nuxt.js/blob/dev/packages/webpack/src/plugins/warnfix.js#L12 too ? |
@kevinmarrec yes, please. seems a more reasonable name now |
PR should be fine now, i'm not sure if it's relevant adding documentation for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types of changes
Description
Refactor some internals so it can fits to the outsourcing/externalization of the typescript support.
Ability to make modules extend Builder supportedExtensions + refactor of
createRoutes
function signature to fit better and pass these supported extensions.Ability to make modules customize Webpack WarningFix plugin filters.
Ability to make modules grab the Nuxt babelLoader (with our predefined babel options) to use it when extending webpack config. Useful to use it with in typescript module with
ts-loader
to handletsx
files.Related : #5858
Checklist: