Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): enforce default css when used with frameworks #6255

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Aug 20, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

When used with TailwindCSS, svg is set as display: block; so the percent is displayed at the bottom of the logo for build-indicator.

Checklist:

  • All new and existing tests are passing.

@pi0 pi0 merged commit fda1b1b into dev Aug 20, 2019
@pi0 pi0 added this to Done in Nuxt v2.10 Aug 21, 2019
@pi0 pi0 mentioned this pull request Aug 22, 2019
@manniL manniL deleted the fix/build-indicator branch August 26, 2019 21:43
Atinux pushed a commit that referenced this pull request Aug 28, 2019
* [release]

* fix(vue-app): enforce default css when used with frameworks (#6255)

* chore(deps): update dependency serialize-javascript to ^1.8.0 (#6254)

* fix(config): provide typescript backward compatibility (#6258)

* fix(vue-app): only overwrite leave listener when none provided or without done arg (#6264)

* fix(nuxt-start): add missing `vue-client-only` dependency (#6267)

* fix(server): treat `https: null` as `https: undefined` (#6265)

* chore(deps): update devdependency rollup to ^1.20.0 (#6268)

* fix: improve watching experience for generated files (#6257)

* refactor(core): use hable (#6271)

* test: disable terser/minify by default (#6290)

* chore(deps): update devdependency rollup to ^1.20.1 (#6282)

* chore(cli): accept hooks (#6274)

* chore(deps): update devdependency rollup-plugin-alias to v2 (#6281)

* fix(builder): apply overrides from app dir only (#6283)

[release]

* feat: function watchQuery (#6245)

* Revert "feat: function watchQuery (#6245)" (#6296)

This reverts commit 3c61830.

* chore(deps): update devdependency rollup to ^1.20.2 (#6295)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* test(vue-app): add template compiler helper (#6299)

* test: add jest roots for less greedy test search (#6300)

* test: remove unnecessary generate (#6301)

* fix: update the minimal require node version in distributions (#6310)

* chore(deps): update devdependency babel-eslint to ^10.0.3 (#6304)

* chore(deps): lock file maintenance (#6305)

* chore: upgrade circleci config to v2.1 (#6312)

* test: add test for modern bundle size (#6302)

* test: add client-only test to basic fixture (#6315)

test: check for no-ssr deprecation warning
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Nuxt v2.10
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants