fix: improve watching experience for generated files #6257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #6257 +/- ##
==========================================
- Coverage 95.76% 95.73% -0.03%
==========================================
Files 80 80
Lines 2666 2673 +7
Branches 687 689 +2
==========================================
+ Hits 2553 2559 +6
- Misses 97 98 +1
Partials 16 16
Continue to review full report at Codecov.
|
clarkdo
previously approved these changes
Aug 20, 2019
|
Expecting the strange failing test 🤔 |
pimlie
approved these changes
Aug 21, 2019
clarkdo
approved these changes
Aug 21, 2019
Atinux
approved these changes
Aug 21, 2019
Merged
Atinux
pushed a commit
that referenced
this pull request
Aug 28, 2019
* [release] * fix(vue-app): enforce default css when used with frameworks (#6255) * chore(deps): update dependency serialize-javascript to ^1.8.0 (#6254) * fix(config): provide typescript backward compatibility (#6258) * fix(vue-app): only overwrite leave listener when none provided or without done arg (#6264) * fix(nuxt-start): add missing `vue-client-only` dependency (#6267) * fix(server): treat `https: null` as `https: undefined` (#6265) * chore(deps): update devdependency rollup to ^1.20.0 (#6268) * fix: improve watching experience for generated files (#6257) * refactor(core): use hable (#6271) * test: disable terser/minify by default (#6290) * chore(deps): update devdependency rollup to ^1.20.1 (#6282) * chore(cli): accept hooks (#6274) * chore(deps): update devdependency rollup-plugin-alias to v2 (#6281) * fix(builder): apply overrides from app dir only (#6283) [release] * feat: function watchQuery (#6245) * Revert "feat: function watchQuery (#6245)" (#6296) This reverts commit 3c61830. * chore(deps): update devdependency rollup to ^1.20.2 (#6295) Co-authored-by: Renovate Bot <bot@renovateapp.com> * test(vue-app): add template compiler helper (#6299) * test: add jest roots for less greedy test search (#6300) * test: remove unnecessary generate (#6301) * fix: update the minimal require node version in distributions (#6310) * chore(deps): update devdependency babel-eslint to ^10.0.3 (#6304) * chore(deps): lock file maintenance (#6305) * chore: upgrade circleci config to v2.1 (#6312) * test: add test for modern bundle size (#6302) * test: add client-only test to basic fixture (#6315) test: check for no-ssr deprecation warning
This was referenced Nov 12, 2019
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Nuxt has a frustrating DX issue when a page file is deleted or renamed. Webpack starts to rebuild as soon as the file is changed while still generated files (like
.nuxt/router.js) are referring to the old file. This is happening because we debouncegenerateRoutesAndFilesfunction (also there is a little generation/fs process time) but webpack rebuilds as soon as possible. Causing a failing intermediate build like this:This PR set a longer default for aggregateTimeout (200ms + ~800ms of generating process). That fixes the problem in normal cases when generation takes less than 800ms: (previously deadline was ~100ms)
Webpack watch will be also suspended during generate files and resumed/invalidated thanks to pausing/resume introduced webpack/webpack#9214 (@jkzing ❤️)
Checklist: