chore: rename dev:prepare to prepare #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The reason this is not named prepare is because of an npm bug that, in some circumstances, runs prepare immediately before packing, meaning that even if you build the project in a prepack step, the built files are then replaced with stubs in the tarball. |
|
Thanks for PR. Another issue is that I understand that it is not best command but is one time only. Later we shall improve module builder and nuxi to automate prepare. |
tobiasdiez
added a commit
to tobiasdiez/nuxt-graphql-server
that referenced
this pull request
Mar 4, 2023
Fixes #34. Prepare is not the correct hook as discussed in nuxt/starter#156.
tobiasdiez
added a commit
to tobiasdiez/nuxt-graphql-server
that referenced
this pull request
Mar 4, 2023
Fixes #34. Prepare is not the correct hook as discussed in nuxt/starter#156.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the tsconfig in the root references the tsconfig of the playground, one has to call
nuxi prepare playgroundbefore running everything else. In particular, it is needed beforeprepack. Renamingdev:preparetopreparetakes care of this automatically.