Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #1339

Closed
benjamincanac opened this issue Feb 8, 2024 — with Volta.net · 7 comments · Fixed by #1364
Closed

Tests #1339

benjamincanac opened this issue Feb 8, 2024 — with Volta.net · 7 comments · Fixed by #1364
Labels
v3 #1289

Comments

Copy link
Member

We only have tests for the Button and Skeleton at the moment.

@romhml
Copy link
Collaborator

romhml commented Feb 18, 2024

I can work on adding tests for the Form component if needed.

@benjamincanac
Copy link
Member Author

@romhml This would be awesome yes! Would you do it directly on #1364 as it's been init there.

@jrutila
Copy link
Contributor

jrutila commented Jul 10, 2024

It would be cool to write a script that goes through all the component examples in the doc and save the snapshots from there. This way the test would always find the examples and compare them to the snapshots that nothing has changed.

Copy link
Member Author

@jrutila This will be done in v3, we already have 795 written: https://github.com/benjamincanac/ui3/tree/dev/test/components
CleanShot 2024-07-10 at 12.58.40@2x.png

@jrutila
Copy link
Contributor

jrutila commented Jul 10, 2024

Great to see that! I get this is done in the components-test branch? Have you updated docs, yet? Would you like some PR for that?

Copy link
Member Author

What do you mean? I sent you the link of the fork we're using to develop v3.

@jrutila
Copy link
Contributor

jrutila commented Jul 10, 2024

Sorry, missed the link. Carry on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants