Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] cannot close USlideover on mobile #192

Closed
sandros94 opened this issue May 18, 2023 · 3 comments · Fixed by #211
Closed

[Documentation] cannot close USlideover on mobile #192

sandros94 opened this issue May 18, 2023 · 3 comments · Fixed by #211
Labels
bug Something isn't working

Comments

@sandros94
Copy link
Collaborator

Version

Current docs

Reproduction Link

While browsimg the nuxtlab-ui documentation on mobile, if I open up the slideover component example I cannot close it since it becomes full-width.

Steps to reproduce

On mobile open up the slideover example in the docs. Once open is not possible to close it for screens where the width matches the width of the component.

What is Expected?

Using the nav back of the device it should close the slideover.

What is actually happening?

Instead it navigates back to the last page visited.

@sandros94 sandros94 added the bug Something isn't working label May 18, 2023
@sandros94
Copy link
Collaborator Author

Just for visual information, here's the USlideover open on mobile:
Screenshot_2023-05-19-13-55-06-37_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

Copy link
Member

Indeed, I will add a close button in the example. Thanks 😊

@sandros94
Copy link
Collaborator Author

One question raised in my mind: how could we make that the system back navigation (os agnostic) could handle the slideover close?

Wouldn't this be a nice UX addition? Maybe making it disableable with a prop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants