Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tabs): handle icon margin in RTL mode #2233

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix(Tabs): handle icon margin in RTL mode #2233

merged 1 commit into from
Sep 23, 2024

Conversation

Malik-Jouda
Copy link
Contributor

@Malik-Jouda Malik-Jouda commented Sep 21, 2024 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Before:
Screenshot 2024-09-22 at 12 34 31 AM
After:
Screenshot 2024-09-22 at 12 35 33 AM

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Malik-Jouda Malik-Jouda changed the title fix(Tabs): handle icon ’margin’ in RTL mode fix(Tabs): handle icon margin in RTL mode Sep 21, 2024
@benjamincanac benjamincanac merged commit ea05414 into nuxt:dev Sep 23, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊

@Malik-Jouda Malik-Jouda deleted the fix/tabs-in-rtl branch September 25, 2024 12:28
patrick-hofmann pushed a commit to patrick-hofmann/nuxt-ui that referenced this pull request Oct 3, 2024
@Malik-Jouda @patrick-hofmann
fix(Tabs): handle icon margin in RTL mode (nuxt#2233)
1d69ca3
@FroudeDescartes FroudeDescartes mentioned this pull request Oct 30, 2024
Open
@numselli numselli mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Malik-Jouda @benjamincanac