Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UButtonGroup does not affect USelectMenu #427

Closed
wvffle opened this issue Jul 18, 2023 · 1 comment · Fixed by #432
Closed

UButtonGroup does not affect USelectMenu #427

wvffle opened this issue Jul 18, 2023 · 1 comment · Fixed by #432
Labels
bug Something isn't working

Comments

@wvffle
Copy link

wvffle commented Jul 18, 2023

Right, but doesn't that break a compatibility with UButtonGroup? That component is so cleverly designed that it can be used for creating groups with other components than just buttons. It replaces the ui.rounded prop and in case of the USelectMenu, that functionality breaks.

Originally posted by @wvffle in #418 (comment)

Version

@nuxthq/ui: ^2.2.0
nuxt: ^3.5.0

Reproduction

<UButtonGroup>
  <USelectMenu :options="options" />
  <UInput v-model="value" />
</UButtonGroup>

Steps to reproduce

What is Expected?

Corners of USelectMenu should be rounded only on one side.

ui.rounded should be passed to USelect as per #418 (comment) and #418 (comment)

What is actually happening?

All corners are rounded, also #418

@wvffle wvffle added the bug Something isn't working label Jul 18, 2023
Copy link
Member

The only way to fix this would be to invert the ui and ui-select props. ui would target the select / button and ui-select would be renamed to ui-menu but this would cause a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants