You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality)
✨ New feature (a non-breaking change that adds functionality)
🧹 Chore (updates to the build process or auxiliary tools and libraries)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)
📚 Description
This is a non-breaking change that will allow users to divide links into sections within the VerticalNavigation component. There was currently a workaround that I mentioned here, but I thought this would be a good enhancement to the component.
All we are doing here is allowing the links prop to either be what it currently is, an array of VerticalNavigationLink (VerticalNavigationLink[]), or now an array of arrays of VerticalNavigationLink (VerticalNavigationLink[][]).
We then introduce a linksSections computed property to ensure we are always working with VerticalNavigationLink[][]. In the template, we show a UDivider between every section unless it's the last section.
Agree. This is definitely a "nice-to-have" feature. I will say I think it could provide some consistency with how we structure and group items in a Dropdown. But good with me if you just want to close this 😊
@benjamincanac conflicts have been resolved. I might be missing something here, but I am using the Divider component. I do have styles for it in the ui.config and that's so that it can be customized through the VerticalNavigation component. Is that what you mean by new styles?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connerblanton
changed the title
🔗 Linked issue
#951
❓ Type of change
📚 Description
This is a non-breaking change that will allow users to divide links into sections within the
VerticalNavigationcomponent. There was currently a workaround that I mentioned here, but I thought this would be a good enhancement to the component.All we are doing here is allowing the
linksprop to either be what it currently is, an array ofVerticalNavigationLink(VerticalNavigationLink[]), or now an array of arrays ofVerticalNavigationLink(VerticalNavigationLink[][]).We then introduce a
linksSectionscomputed property to ensure we are always working withVerticalNavigationLink[][]. In the template, we show aUDividerbetween every section unless it's the last section.Resolves #951
📝 Checklist