Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use an overlay for UPopover #984

Closed
genu opened this issue Nov 16, 2023 · 2 comments · Fixed by #1014
Closed

Add ability to use an overlay for UPopover #984

genu opened this issue Nov 16, 2023 · 2 comments · Fixed by #1014
Labels
enhancement New feature or request

Comments

@genu
Copy link
Contributor

genu commented Nov 16, 2023

Description

Using the popover from headlessui allows a Popover to have an overlay using the PopoverOverlay component.

See Here for more info

Based on review of the Popover component here, it doesn't look like its possible now to even use the overlay component from healdessui directly.

Additional context

No response

@genu genu added the enhancement New feature or request label Nov 16, 2023
@genu genu changed the title Allow ability to use an overlay for UPopover Add ability to use an overlay for UPopover Nov 16, 2023
Copy link
Member

We can definitely add this! When first implementing the component, I didn't bother with this as I didn't see a use-case.

@genu
Copy link
Contributor Author

genu commented Nov 24, 2023

@benjamincanac Can we add similar functionality to Dropdown component?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants