Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): add ability to custom style for td and tr #741

Merged
merged 8 commits into from
Sep 28, 2023

Conversation

Haythamasalama
Copy link
Contributor

@Haythamasalama Haythamasalama commented Sep 25, 2023

πŸ”— Linked issue

Resolves #736

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add the ability to apply custom styles to tr and td elements by passing a class to rows.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
ui βœ… Ready (Inspect) Visit Preview Sep 28, 2023 10:03am

@benjamincanac
Copy link
Member

Thanks @Haythamasalama! Just checked the deployment, the example looks fine on light mode but not on dark mode, could you add dark variants?

@Haythamasalama
Copy link
Contributor Author

Thanks @Haythamasalama! Just checked the deployment, the example looks fine on light mode but not on dark mode, could you add dark variants?

Ok

Comment on lines +530 to +531

Also, you can apply styles to `th` elements by passing a `class` to columns.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I have included instructions on how to format columns.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this

@benjamincanac benjamincanac merged commit 874447c into nuxt:dev Sep 28, 2023
2 checks passed
@Haythamasalama Haythamasalama deleted the feat/allow-custom-style-td-tr branch September 28, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamic classes to row
3 participants