Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components without $el will cause destroy hook to fail #187

Closed
elrolito opened this issue Feb 12, 2018 · 2 comments
Closed

Components without $el will cause destroy hook to fail #187

elrolito opened this issue Feb 12, 2018 · 2 comments

Comments

@elrolito
Copy link

https://github.com/declandewet/vue-meta/blob/776ddf62a233079dbd0c90cfdd8f8fc749188fcd/src/shared/plugin.js#L89-L93

Using vuelidate creates components that do not have an $el property, but still have _hasMetaInfo set to true, which results in the setInterval never being cleared. There may be other plugins that create similar components.

Changing the line to if (this.$el && this.$el.offsetParent !== null) return would resolve this issue.

@atinux
Copy link
Member

atinux commented Mar 13, 2018

Thank you for reporting this issue, it's fixed by #196

@elrolito
Copy link
Author

Cool, thanks. Glad I could help. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants