fix: try to only parse meta once during ssr build #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
approved these changes
Mar 13, 2023
antfu
reviewed
Mar 13, 2023
|
I don't get why tests are failing on slots after this change. It works when I directly use the library 🤔 @farnabaz I think errors are related #52 (comment) |
|
@stafyniaksacha ; we have same issue on #52 ; @johnsoncodehk is looking after it :) |
Tahul
approved these changes
Mar 16, 2023
|
(waiting for upstream fix / guidelines on how to solve slots problem) |
|
Issue mentioned above resolved in other PRs, this looks good to me as well! Thanks @stafyniaksacha :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since result is written to disk and only used by nitro, we can avoid computing it twice