-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quickstart #20
Quickstart #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cwharris
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to sync on a few things:
- Organization
- I like the
00_Name
format but the first one shouldnt be called "Quickstart". Are we only going to have one example (And the number isnt necessary)?
- I like the
- How much the python and C++ examples will mirror each other
3. The way things are done in python and C++ is a bit different. We could have line level parity if we wanted to - What exactly we want to show
- The first example should be easy and then build up. But it doesnt look like that was the plan from your first pass. Do you intend to have more examples?
I think post 22.08 will be the best time to include that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good overall. Added a few comments + suggestion.
Co-authored-by: Devin Robison <drobison00@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the QSG is good and a very nice v1. We can iterate on it going forward. None of the changes I mentioned are mandatory, so approving this as-is. I couldn't find two of the README
files for the C++ examples (perhaps I overlooked them), so we'd want to address that in short order if it's indeed an issue. Also, there are some minor nits in the example README
s about the benefit of including 1-2 sentences at the end explaining the output and what's happening to the user. Overall, this is solid work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
fix broken link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't request changes on my own PR...
Co-authored-by: Ryan Olson <ryanolson@users.noreply.github.com>
@gpucibot merge |
No description provided.