Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding PortGraph; validate Pipeline definitions #28

Merged
1 commit merged into from
Jun 14, 2022

Conversation

ryanolson
Copy link
Contributor

Fixes #27 by throwing an exception when registering a pipeline with an incomplete or currently invalid port configuration.

… this object to ensure valid assignment / configuration are applied
@ryanolson ryanolson requested review from a team as code owners June 14, 2022 04:16
@ryanolson ryanolson added bug Something isn't working non-breaking Non-breaking change labels Jun 14, 2022
@ryanolson
Copy link
Contributor Author

ok to test

Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/internal/executor/executor.cpp Show resolved Hide resolved
@ryanolson ryanolson changed the base branch from main to branch-22.06 June 14, 2022 23:20
@ryanolson
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit 15c2727 into nv-morpheus:branch-22.06 Jun 14, 2022
@ryanolson ryanolson deleted the validate_ports branch June 14, 2022 23:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Segments created with unconnected ingress ports hang on shutdown.
2 participants