Improved Resource ownership #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
requested changes
Jun 22, 2022
|
It is a lot less intertwined now. |
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
mdemoret-nv
approved these changes
Jun 24, 2022
|
@gpucibot merge |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
Fixes #36
The primary issue that was causing #36 is shared_ptr creep. Usually the deferred deletion / pseudo-garbage collection enabled by shared_ptrs is useful, but in this case, the resources that own the worker threads are held in objects that are managed by shared_ptrs. In some cases, the worker threads are the last owners of these shared ptrs and thus exhibit a deadlock where a thread ultimately tries to join itself.
This PR removes all shared_ptrs from object/resources that could be potentially captured by worker threads and replaces them with references.
The code is structured so that all resources and worker threads are owned by the
Executor->resources::Managerand that all threads must be joined beforeresources::Manageris destroyed.This ensures that the resources outlive the pipeline execution provided that the Executor stays in scope. If it goes out of scope or is destroyed it should issue a kill to the pipeline, but still block until all threads are joined.
All executor resources should be created and managed by
resources::Manageras a single point for life cycle management.