-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Cleanup #47
Merged
Merged
General Cleanup #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le since they have a single header
mdemoret-nv
added
non-breaking
Non-breaking change
feature request
New feature or request
labels
Jun 22, 2022
@drobison00 and @ryanolson Can I get a re-review? |
ryanolson
approved these changes
Jun 24, 2022
drobison00
approved these changes
Jun 24, 2022
@gpucibot merge |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the folllowing:
SRF_USE_CONDA=ON
as the defaultsrf::make_pipeline()
in favor ofsrf::pipeline::make_pipeline()
./python
#include "srf/...
to the correct#include <srf/...>
architect
andtest
to be checked by CI#pragma once
to the cpp_tests.shcommon_sinks.cpp
andcommon_sources.cpp
into a single file since they have a single header.include/srf/internal
toinclude/srf/engine
Closes #48