Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements Needed for Quickstart #52

Merged
2 commits merged into from
Jun 23, 2022
Merged

Improvements Needed for Quickstart #52

2 commits merged into from
Jun 23, 2022

Conversation

mdemoret-nv
Copy link
Contributor

There are some changes that are necessary to test the Quickstart guide from the conda package. This PR makes those changes so that once they are merged, a conda package can be built allowing for the QSG to be tested.

Some improvements:

  • Improves the python build system in CMake to be fully generic
    • This follows the design built and used in Morpheus
    • Improves on the design by allowing multiple python packages to be built in the same CMake project
    • Also adds python stub files to SRF

@mdemoret-nv mdemoret-nv requested review from a team as code owners June 23, 2022 21:29
@mdemoret-nv mdemoret-nv added non-breaking Non-breaking change feature request New feature or request labels Jun 23, 2022
dagardner-nv
dagardner-nv approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

drobison00
drobison00 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Everything looked reasonable in the quick start; if we're just building two new packages should be fine.

@mdemoret-nv
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit 6f24e79 into nv-morpheus:branch-22.06 Jun 23, 2022
@mdemoret-nv mdemoret-nv deleted the mdd_quickstart-prefixes branch June 24, 2022 05:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanolson ryanolson ryanolson approved these changes

@drobison00 drobison00 drobison00 approved these changes

@dagardner-nv dagardner-nv dagardner-nv approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdemoret-nv @ryanolson @drobison00 @dagardner-nv