-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update brlapi to 0.7 #14
Conversation
Hi, No errors this time. Note that just copying the CP37 extension (pyd) may suffice, as doing that produces no errors. But for sake of completeness, I think it'd be best to upgrade to brlapi 0.7. Thanks. |
brlapi will only import with the 0.7 dll.
… Op 13 jun. 2019 om 16:26 heeft Joseph Lee ***@***.***> het volgende geschreven:
Hi,
No errors this time. Note that just copying the CP37 extension (pyd) may suffice, as doing that produces no errors. But for sake of completeness, I think it'd be best to upgrade to brlapi 0.7.
Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
it might be handy to have debug symbols as well. Is it possible to generate those too? |
Wow! Ehm, I have no idea. These libs are all compiled with mingw32, so I don't think that's able to provide msvc compatible debug symbols.
… Op 13 jun. 2019 om 17:20 heeft Reef Turner ***@***.***> het volgende geschreven:
it might be handy to have debug symbols as well. Is it possible to generate those too?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Producing debug versions of the dll should just require using the An intro here: https://stackoverflow.com/questions/4671900/how-do-i-use-the-mingw-gdb-debugger-to-debug-a-c-program-in-windows I would take a look at the There is also the possibility to convert debug information to pdb. |
I will give it a try.
|
Though, since we did not have them before, we may not need them now. But since you have gone to the effort of building this, we might as well spend a little time to investigate getting debug info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My opinion is that we shouldn't hold this back for debugging -- we never had it anyway. Note that without this, the braille gestures unit test is freezing on appveyor.
@LeonarddeR I assume you've been able to successfully use this in NVDA with brlTty? |
@michaelDCurran: honestly, not yet. I only tested whether a Python 3 instance of NVDA was able to load the extension module and whether I could call functions on the module. It is likely that the brltty driver needs updates to support the update from 0.5x to 0.7x. |
I've now come as far as connecting to the brlapi service from the new binding. Unfortunately, I can't get BRLTTY to work with my Handy Tech Active Braille, but that's definitely an issue I'm having with BRLTTY, not with NVDA. I think it is save to merge this. Then, I will file a follow up pr to update misc-deps and the BRLTTY driver itself |
After hours of pine, I've finally been able to build the brltty bindings for Python 3.7. Here is a summary of the build steps: