Skip to content

Commit

Permalink
The NVDA error sound is no longer played in release candidates and fi…
Browse files Browse the repository at this point in the history
…nal releases. Note that errors are still logged.
  • Loading branch information
jcsteh committed Nov 5, 2009
1 parent a8e0b3a commit 0863820
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
5 changes: 4 additions & 1 deletion source/logHandler.py
Expand Up @@ -133,9 +133,12 @@ def exception(self, msg="", exc_info=True):
class FileHandler(logging.FileHandler):

def handle(self,record):
# Late import because versionInfo requires gettext, which isn't yet initialised when logHandler is first imported.
import versionInfo
if record.levelno>=logging.CRITICAL:
winsound.PlaySound("SystemHand",winsound.SND_ALIAS)
elif record.levelno>=logging.ERROR:
elif record.levelno>=logging.ERROR and versionInfo.isTestVersion:
# Only play the error sound if this is a test version.
try:
nvwave.playWaveFile("waves\\error.wav")
except:
Expand Down
2 changes: 2 additions & 0 deletions source/versionInfo.py
Expand Up @@ -49,3 +49,5 @@ def _updateVersionFromVCS():
Or see the file Copying.txt that came with this software.""")%globals()

_updateVersionFromVCS()
# A test version is anything other than a final or rc release.
isTestVersion = not version[0].isdigit() or "alpha" in version or "beta" in version
1 change: 1 addition & 0 deletions user_docs/en/whats new.txt
Expand Up @@ -44,6 +44,7 @@ Major highlights of this release include support for 64 bit editions of Windows;
* the navigatorObject_where script (ctrl+NVDA+numpad5) has been removed. This key combination did not work on some keyboards, nore was the script found to be that useful.
* the navigatorObject_currentDimentions script has been remapped to NVDA+numpadDelete. The old key combination did not work on some keyboards. This script also now reports the width and height of the object instead of the right/bottom coordinates.
* Improved performance (especially on netbooks) when many beeps occur in quick succession; e.g. fast mouse movement with audio coordinates enabled. (#396)
* The NVDA error sound is no longer played in release candidates and final releases. Note that errors are still logged.

=== Bug Fixes ===
* When NVDA is run from an 8.3 dos path, but it is installed in the related long path (e.g. progra~1 verses program files) NVDA will correctly identify that it is an installed copy and properly load the user's settings.
Expand Down

0 comments on commit 0863820

Please sign in to comment.