Skip to content

Commit

Permalink
Make add-on reviews available from all tabs of the store (#16368)
Browse files Browse the repository at this point in the history
Fixes #16179

Summary of the issue:
The community reviews action, and the reviews URL, is not available in installed and incompatible add-ons tab of the store.

Description of user facing changes
The community reviews action, and the reviews URL, will be available in all tabs of the store.

Description of development approach
Fix reviewUrl variable assignment in the _createInstalledStoreModelFromData function of addonStore/models/addon.py
  • Loading branch information
nvdaes committed Apr 7, 2024
1 parent 30aa12d commit 103244e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion source/addonStore/models/addon.py
Expand Up @@ -303,7 +303,7 @@ def _createInstalledStoreModelFromData(addon: Dict[str, Any]) -> InstalledAddonS
sha256=addon["sha256"],
minNVDAVersion=MajorMinorPatch(**addon["minNVDAVersion"]),
lastTestedVersion=MajorMinorPatch(**addon["lastTestedVersion"]),
reviewURL=addon.get("reviewUrl"),
reviewURL=addon.get("reviewURL"),
legacy=addon.get("legacy", False),
)

Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
Expand Up @@ -58,6 +58,7 @@ What's New in NVDA
- Fixed a bug where audio coordinates would be played while the application is in sleep mode when "Play audio coordinates when mouse moves" is enabled. (#8059, @hwf1324)
- Add-on Store:
- When pressing ``ctrl+tab``, focus properly moves to the new current tab title. (#14986, @ABuffEr)
- The community reviews action will be available, and the reviews webpage will be shown in the details panel, in all tabs of the store (#16179, @nvdaes)
-
- In Adobe Reader, NVDA no longer ignores alternative text set on formulas in PDFs. (#12715)
- Changed several gestures for BrailleSense devices to avoid conflicts with characters of the French braille table. (#15306)
Expand Down
6 changes: 3 additions & 3 deletions user_docs/en/userGuide.t2t
Expand Up @@ -3016,9 +3016,9 @@ Just like when you install or remove add-ons, you need to restart NVDA in order
You can also enable or disable multiple add-ons at once by selecting multiple add-ons in the available add-ons tab, then activating the context menu on the selection and choosing the appropriate action.

+++ Reviewing add-ons and reading reviews +++[AddonStoreReviews]
Before installing an add-on, you may want to read reviews by others.
Also, it may be helpful to other users to provide feedback about add-ons you have tried.
To read reviews for an add-on, select an add-on from the Available or Updatable add-ons tab, and use the "Community reviews" action.
You may want to read reviews by other users who have experienced an add-on, for example before you install it, or as you are learning to use it.
Also, it is helpful to other users to provide feedback about add-ons you have tried.
To read reviews for an add-on, select it, and use the "Community reviews" action.
This links to a GitHub Discussion webpage, where you will be able to read and write reviews for the add-on.
Please be aware that this doesn't replace direct communication with add-on developers.
Instead, the purpose of this feature is to share feedback to help users decide if an add-on may be useful for them.
Expand Down

0 comments on commit 103244e

Please sign in to comment.