Skip to content

Commit

Permalink
Review actions.
Browse files Browse the repository at this point in the history
  • Loading branch information
feerrenrut committed Apr 26, 2022
1 parent 183f2a4 commit 33153d6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions nvdaHelper/localWin10/oneCoreSpeech.cpp
Expand Up @@ -295,7 +295,7 @@ bool __stdcall ocSpeech_supportsProsodyOptions() {
}

std::wstring createMarkersString_(IVectorView<IMediaMarker> markers) {
std::wstring markersStr; // for large strings, reserving would speed this up.
std::wstring markersStr; // for large strings, preallocating / reserving may speed this up.
bool firstComplete = false;
for (auto const& marker : markers) {
if (firstComplete) {
Expand Down Expand Up @@ -433,8 +433,9 @@ bool isUniversalApiContractVersion_(const int major, const int minor) {
}



void preventEndUtteranceSilence_(std::shared_ptr<winrtSynth> synth) {
// By default, OneCore speech appends a large annoying chunk of silence at the end of every utterance.
// By default, OneCore speech appends a large annoying chunk of silence at the end of every utterance.
// Newer versions of OneCore speech allow disabling this feature, so turn it off where possible.
const bool isAppendSilenceAvailable = isUniversalApiContractVersion_(6, 0);
if (isAppendSilenceAvailable) {
Expand Down
2 changes: 1 addition & 1 deletion nvdaHelper/localWin10/oneCoreSpeech.h
Expand Up @@ -13,7 +13,7 @@
- Internal function 'speak' is run asynchronously using Windows thread pool.
Results are passed back to NVDA via a callback, which must still be valid when the results are ready.
However, terminate will invalidate the callback.
To protect against this, locking strategy is used.
To protect against this, a locking strategy is used.
Before the callback is executed a shared_lock is acquired on the mutex, this allows other shared locks
to be acquired, but prevents unique locks from acquiring the mutex.
Expand Down

0 comments on commit 33153d6

Please sign in to comment.