Pending update installation: obtain version tuple from update tuple i…

…nstead of going through version info module (PR #9076)

Fixes #9075

Possible oversight from add-on compatibility checks: 'instlal pending update' fails becasue version tuple is derived from version info module when in fact version tuple can be retrieved from update check/pending update state. Thus use the latter so confirmation dialog can work.

source/gui/__init__.py

@@ -214,10 +214,10 @@ def onTemporaryDictionaryCommand(self,evt):
 	def onExecuteUpdateCommand(self, evt):
 		if updateCheck and updateCheck.isPendingUpdate():
 			updateTuple = updateCheck.getPendingUpdate()
-			newNVDAVersionTuple = versionInfo.getNVDAVersionTupleFromString(updateTuple[1])
+			newNVDAVersionTuple = updateTuple[2]
 			from addonHandler import getAddonsWithoutKnownCompatibility
 			if any(getAddonsWithoutKnownCompatibility(newNVDAVersionTuple)):
-				confirmUpdateDialog = updateCheck.UpdateAskInstallDialog(gui.mainFrame, updateTuple[0], updateTuple[1])
+				confirmUpdateDialog = updateCheck.UpdateAskInstallDialog(gui.mainFrame, updateTuple[0], updateTuple[1], newNVDAVersionTuple)
 				gui.runScriptModalDialog(confirmUpdateDialog)
 			else:
 				updateCheck.executePendingUpdate()
@@ -861,10 +861,10 @@ def onOk(self, evt):
 		elif action == 4:
 			if updateCheck:
 				updateTuple = updateCheck.getPendingUpdate()
-				newNVDAVersionTuple = versionInfo.getNVDAVersionTupleFromString(updateTuple[1])
+				newNVDAVersionTuple = updateTuple[2]
 				from addonHandler import getAddonsWithoutKnownCompatibility
 				if any(getAddonsWithoutKnownCompatibility(newNVDAVersionTuple)):
-					confirmUpdateDialog = updateCheck.UpdateAskInstallDialog(gui.mainFrame, updateTuple[0], updateTuple[1])
+					confirmUpdateDialog = updateCheck.UpdateAskInstallDialog(gui.mainFrame, updateTuple[0], updateTuple[1], newNVDAVersionTuple)
 					confirmUpdateDialog.ShowModal()
 				else:
 					updateCheck.executePendingUpdate()