Skip to content

Commit

Permalink
No longer set the language before restarting (PR #6415)
Browse files Browse the repository at this point in the history
Fixes #4561
When a new language is selected (on the general settings dialog) and the ok
button is pushed, the language is not changed until until NVDA is restarted.

This fixes an issue where some parts of the UI are translated and some
are not.
  • Loading branch information
feerrenrut committed Oct 27, 2016
1 parent 516fc27 commit 91159a2
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions source/gui/settingsDialogs.py
Expand Up @@ -257,13 +257,6 @@ def onCopySettings(self,evt):

def onOk(self,evt):
newLanguage=[x[0] for x in self.languageNames][self.languageList.GetSelection()]
if newLanguage!=self.oldLanguage:
try:
languageHandler.setLanguage(newLanguage)
except:
log.error("languageHandler.setLanguage", exc_info=True)
gui.messageBox(_("Error in %s language file")%newLanguage,_("Language Error"),wx.OK|wx.ICON_WARNING,self)
return
config.conf["general"]["language"]=newLanguage
config.conf["general"]["saveConfigurationOnExit"]=self.saveOnExitCheckBox.IsChecked()
config.conf["general"]["askToExit"]=self.askToExitCheckBox.IsChecked()
Expand Down

0 comments on commit 91159a2

Please sign in to comment.