Skip to content

Commit

Permalink
Target Windows 10 using its GUID. re #4760
Browse files Browse the repository at this point in the history
Starting with Windows 8.1, Microsoft recommends developers to use ap manifests to specify OS compatibility instead of relying on version info tuple (which Python returns via Windows API). This was used for fixing ticket 3793 (targeting Windows 8.).
This also applies to Windows 10 in that it has its oww GUID. Without this Windows 10 tells NVDA that it is Windows 8.1 (NT6.3, not NT6.4/10.0). Thus the new GUID for Windows 10 was added to declare that NVDA supports Windows 10.
  • Loading branch information
josephsl committed Dec 29, 2014
1 parent d5b17df commit a3193ab
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion source/setup.py
@@ -1,7 +1,7 @@
# -*- coding: UTF-8 -*-
#setup.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2006-2014 NV Access Limited, Peter Vágner
#Copyright (C) 2006-2015 NV Access Limited, Peter Vágner, Joseph Lee
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.

Expand Down Expand Up @@ -54,6 +54,8 @@
<supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
<!-- Windows 8.1 -->
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
<!-- Windows 10 -->
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
</application>
</compatibility>
"""
Expand Down

0 comments on commit a3193ab

Please sign in to comment.