updateCheck, installerGui: Hide the progress dialog before destroying…

… it. For updateCheck, make sure the Python object gets deleted as well.

This seems to fix the crash after updating and the issue where the progress dialog would still show while the message box was being displayed. I'm not sure why this is necessary, but it seems Destroy is delayed somehow.

source/gui/installerGui.py

@@ -124,6 +124,7 @@ def done(self):
 		self.timer.Stop()
 		if self.IsActive():
 			tones.beep(1760, 40)
+		self.Hide()
 		self.Destroy()
 
 class PortableCreaterDialog(wx.Dialog):

source/updateCheck.py

@@ -277,15 +277,19 @@ def _downloadReport(self, read, size):
 		self._progressDialog.Update(percent, _("Downloading"))
 
 	def _error(self):
+		self._progressDialog.Hide()
 		self._progressDialog.Destroy()
+		self._progressDialog = None
 		gui.messageBox(
 			# Translators: A message indicating that an error occurred while downloading an update to NVDA.
 			_("Error downloading update."),
 			_("Error"),
 			wx.OK | wx.ICON_ERROR)
 
 	def _downloadSuccess(self):
+		self._progressDialog.Hide()
 		self._progressDialog.Destroy()
+		self._progressDialog = None
 		# Translators: The message presented when the update has been successfully downloaded
 		# and is about to be installed.
 		gui.messageBox(_("Update downloaded. It will now be installed."),