Replies: 52 comments 130 replies
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
-
@seanbudd it seems the lists in the addon store do not support scroling with ctrl+home or ctrl+end to reach the beginning or the end of the list. I was browsing through the available addons, 96 addons as of now, and was wondering how to reach the beginning of the list again with the keyboard. Also it might make sense to introduce a category label in the addons manifest and a category filter in the addon store and match the category chosen by the author with the filter, or even group addons by category in the addon store (i.e. entertainment, translation, text recognition, productivity, audio management etc.). Otherwise we will end up with a really huge list in the future and grouping them at a later stage might become very difficult. Thank you for the huge work implementing the addon store, this is really amazing. |
Beta Was this translation helpful? Give feedback.
-
We may have to disable or enable certain add-ons one by one when troubleshooting issues caused by add-ons. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
-
Issues CB2 and CB6: Accelerator keys
The accelerator alt+L is present but not discoverable, even with object navigation. On the contrary in the categbory list of the settings dialog, when you press NVDA+pavNum8, you can hear the accelerator.
Alt+O is working but is not discoverable, so almost useless. It is not reported when tabbing into this field nor when pressing shift+Numpad2. |
Beta Was this translation helpful? Give feedback.
This comment has been minimized.
This comment has been minimized.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
-
@seanbudd Is there supposed to be a Windows error ding, when pressing enter on an add-on to open the context menu? Doesn't happen for Alt+a or Applications, does for enter. Version: try-addonStore-base-28263,f75845d8 Probably unrelated proximate log fragmentDEBUG - gui._addonStoreGui.viewModels.store.AddonStoreVM._onSelectedItemChanged (03:25:45.413) - MainThread (2616): Setting selection: AddonListItemVM: tonysEnhancements-stable, AvailableAddonStatus.RUNNING DEBUG - gui._addonStoreGui.viewModels.store.AddonStoreVM._onSelectedItemChanged (03:25:45.413) - MainThread (2616): Setting selection: AddonListItemVM: tonysEnhancements-stable, AvailableAddonStatus.RUNNING IO - speech.speech.speak (03:25:45.423) - MainThread (2616): Speaking ["Tony's enhancements; Installed version: 1.15; Channel: Stable; Publisher: Tony Malykh ; Status: Enabled", '2 of 2', CancellableSpeech (still valid)] DEBUGWARNING - NVDAObjects.IAccessible.IAccessible._getIA2RelationFirstTarget (03:25:45.433) - MainThread (2616): Unable to use _getIA2TargetsForRelationsOfType, fallback to _IA2Relations. DEBUG - NVDAObjects.IAccessible.IAccessible._get__IA2Relations (03:25:45.433) - MainThread (2616): Not an IA2.IAccessible2 DEBUG - NVDAObjects.IAccessible.IAccessible._getIA2RelationFirstTarget (03:25:45.433) - MainThread (2616): Unable to fetch _IA2Relations Traceback (most recent call last): File "NVDAObjects\IAccessible\__init__.pyc", line 1600, in _getIA2RelationFirstTarget File "baseObject.pyc", line 62, in __get__ File "baseObject.pyc", line 168, in _getPropertyViaCache File "NVDAObjects\IAccessible\__init__.pyc", line 1515, in _get__IA2Relations NotImplementedError DEBUG - gui._addonStoreGui.controls.details.AddonDetails._updatedListItem (03:25:45.463) - MainThread (2616): Setting listItem: AddonListItemVM: tonysEnhancements-stable, AvailableAddonStatus.RUNNING IO - inputCore.executeGesture (03:25:47.449) - winInputHook (17952): Input: kb(desktop):enter IO - speech.speech.speak (03:25:47.480) - MainThread (2616): Speaking ['Context', 'menu', CancellableSpeech (still valid)] |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
Hi @seanbudd Following the list of issues reported in #13985 (comment) and #13985 (comment) and your answer in #13985 (comment): First of all, thanks for all the modifications after my comments. Could you please provide a new try build? This way I can check various points that you have fixed or on which you have commented. Thanks. Here are points where I can already answer:
Of course it's not a critical bug. But it would help the overall understanding of the add-on store GUI by users. Keeping this bug would be one more case when NVDA is over verbose where other screen readers are not.
There are already settings set out of NVDA settings dialog in NVDA, e.g. speech viewer position and "show at startup" config. But I agree that the typical UX is the settings dialog.
In the add-on store (still opened), the add-on list is not updated with incompatible add-ons. An alternative implementation would be to set the checkbox in the add-on store anyway, but not to save the config at all. That is the checkbox would unblock the incompatible add-on installation only for the current session. This has the addvantage that the user will not forget that he has bypassed the manifest security once. Personnally, I prefer this last approach. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
It's not a supported key in the current NVDA manifest schema. However, as written by @josephsl, it has been defined in the add-on template and used by the community, by Add-on Updater and other update tools. So it has become a de facto standard in the add-on community.
So if I understand things clearly, an add-on package (.nvdaaddon file) does not hold internally a channel info as it was done before in the community. If yes, the logic would be that I can submit a version 3.2 on the beta channel and if no issue is found the same version 3.2 could be submitted for the stable channel. That was not possible previously and if this becomes possible, it would be nice. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
-
On the pages of Updatable add-ons and Available add-ons, the Channel combo box should not contain the External option, because there is no such possibility |
Beta Was this translation helpful? Give feedback.
-
@seanbudd, regarding point 2:
I have not thought of any similar use case to contrast this to. I think a user may not be expecting a multiline read only edit control here, but I'm not sure what users would expect since it is one. If I come up with an example of a user being able to tab into a multi-line description of something, I'll post it here.
I was thinking of wx.StaticText, but I suppose that won't show up in the tab order as a singular item. Too bad we can't do something like the list used with Windows Explorer, which provides nice arrow navigation of various read only fields. |
Beta Was this translation helpful? Give feedback.
This comment has been minimized.
This comment has been minimized.
-
Since the store can know about multiple versions of an add-on, would it be desirable to allow the store interface to show all known versions? Perhaps another option in the channel dialog when listing available, of " Or a " I had a use case for this today, when I needed to diff the behavior of an older add-on version that's in the store, with the current (most up to date) version. As it is, I had to install the old one manually, after tracking down the GitHub release. |
Beta Was this translation helpful? Give feedback.
-
Now that #13985 has been merged, please open new issues for add-on store issues, as you would for any other issue on alpha.
Discussion of the PR #13985
Discussion is limited to here to make working on the PR easier.
Please use the threaded replies to respond to comments and avoid email based replies.
Emoji reactions have been used to mark threads.
Beta Was this translation helpful? Give feedback.
All reactions