Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update NVDA to 2019.2.1 #10311

Closed
nvdaes opened this issue Oct 2, 2019 · 8 comments
Closed

Unable to update NVDA to 2019.2.1 #10311

nvdaes opened this issue Oct 2, 2019 · 8 comments
Labels
p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority

Comments

@nvdaes
Copy link
Sponsor Contributor

nvdaes commented Oct 2, 2019

Please thoroughly read NVDA's wiki article on how to fill in this template, including how to provide the required files.
Issues may be closed if the required information is not present.
https://github.com/nvaccess/nvda/wiki/Github-issue-template-explanation-and-examples
-->

Steps to reproduce:

  1. Select search for updates or answer yes when NVDA offers 2019.2.1 update.
  2. Try to download update using the dialog.

Actual behavior:

The update is not downloaded and the log shows this error:

ERROR - unhandled exception (11:12:02.313):
Traceback (most recent call last):
File "updateCheck.pyo", line 733, in onClose
File "updateCheck.pyo", line 417, in _download
File "updateCheck.pyo", line 553, in init
KeyError: 'apiVersion'

Expected behavior:

The update should be downloaded and installed.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2019.2.1beta1

Windows version:

7 and 10

Name and version of other software in use when reproducing the issue:

n/a

Other information about your system:

Tested with add-ons disabled.

Other questions

Does the issue still occur after restarting your PC?

Yes.

Have you tried any other versions of NVDA? If so, please report their behaviors.

Yes, NVDA 2019.2.2rc1 (not available now).

@Brian1Gaff
Copy link

Brian1Gaff commented Oct 2, 2019 via email

@feerrenrut
Copy link
Contributor

Thanks for the report, we'll look into this with urgency.

@feerrenrut feerrenrut added the p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Oct 2, 2019
@JulienCochuyt
Copy link
Collaborator

Either this has already been fixed on the update server side, or the updateInfo sent to 2019.2 stable users is not the same: Update works fine here from 2019.2 stable.

@nvdaes
Copy link
Sponsor Contributor Author

nvdaes commented Oct 2, 2019

JulienCochuyt commented 10 minutes ago

Either this has already been fixed on the update server side, or the updateInfo sent to 2019.2 stable users is not the same

For me the issue is not fixed at this moment.

@michaelDCurran
Copy link
Member

This is only affecting beta users. I'm looking into this now.

@michaelDCurran
Copy link
Member

Update server now provides the missing keys (apiVersion and apiCompatTo) when redirecting updates to 2019.2.1 if older than 2019.1, and it now correctly parses beta version strings, which were previously being treated as being older than 2019.1.
Testing shows that betas can now upgrade to 2019.2.1.
Please let me know if this fixes the issue for you.

@nvdaes
Copy link
Sponsor Contributor Author

nvdaes commented Oct 2, 2019

michaelDCurran commented 17 minutes ago

Please let me know if this fixes the issue for you.

This fixes the issue for me. Thanks! I think we can close the issue. I will do now.

@nvdaes nvdaes closed this as completed Oct 2, 2019
@Brian1Gaff
Copy link

Brian1Gaff commented Oct 2, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Development

No branches or pull requests

5 participants