Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NVDA leaves a table when browsing blank cells in MS Word with UIA enabled #11043

Closed
brunoprietog opened this issue Apr 22, 2020 · 2 comments · Fixed by #12731
Closed

NVDA leaves a table when browsing blank cells in MS Word with UIA enabled #11043

brunoprietog opened this issue Apr 22, 2020 · 2 comments · Fixed by #12731
Labels
app/microsoft-office component/UIA-ms-office Specific to UIA used in MS office applications.
Projects
[Project] UIA in Word
Milestone
2021.3

Comments

@brunoprietog
Copy link

With UIA enabled for Microsoft Word, when you navigate a table that contains empty cells, NVDA leaves the table as it passes through that cell, using the Alt+CTRL+Arrow navigation commands. If you navigate only with arrows, for example, with a right arrow to move to that empty cell, it does not report the cell/column/row change.

Steps to reproduce:

With UIA enabled, insert a table in Microsoft Word and try to navigate it with the table navigation commands, or just the arrows. NVDA does not identify the cells.
If you type things into any of the cells and leave other cells empty, you will be able to move correctly through the cells that have text, but you will not be able to move through the blank cells, NVDA leaves the table or does not announce the cell change.

Actual behavior:

NVDA does not identify the blank cells, leaves the table or does not announce the cell change.

Expected behavior:

NVDA announces the cells correctly.

System configuration

NVDA installed/portable/running from source:

Installed and portable

NVDA version:

2020.1 beta 1

Windows version:

Windows 10Ver1909 (64 bits) build 18363.778

Name and version of other software in use when reproducing the issue:

Microsoft Office 16.0.12624.20466

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

I get the same behavior with NVDA 2019.3.1 and 2019.2.1

If addons are disabled, is your problem still occuring?

Yes

Did you try to run the COM registry fixing tool in NVDA menu / tools?

Yes
@fisher729
Copy link

Hi.

I can confirm that this issues occurs.

@brunoprietog brunoprietog reopened this Apr 27, 2020
@feerrenrut feerrenrut added app/microsoft-office component/UIA-ms-office Specific to UIA used in MS office applications. labels Apr 29, 2020
@LeonarddeR LeonarddeR added this to To do in [Project] UIA in Word via automation Aug 6, 2020
@brunoprietog brunoprietog mentioned this issue Sep 5, 2020
Closed
@aaclause aaclause mentioned this issue Sep 6, 2020
Closed
@brunoprietog brunoprietog mentioned this issue Sep 20, 2020
Open
@brunoprietog
Copy link
Author

@LeonarddeR @feerrenrut @michaelDCurran Friends, have you been able to investigate this error? It is being very critical for many people. Thank you very much in advance.

@brunoprietog brunoprietog mentioned this issue Jun 7, 2021
Closed
@michaelDCurran michaelDCurran mentioned this issue Aug 12, 2021
Merged
8 tasks
[Project] UIA in Word automation moved this from To do to Done Aug 16, 2021
michaelDCurran added a commit that referenced this issue Aug 16, 2021
@michaelDCurran
Correctly read blank cells in MS Word with NVDA's UIA for MS Word opt…
733ead7 
…ion enabled (#12731)

When using UIA to access Microsoft word documents with NVDA, NVDA failed to announce row and column numbers when arrowing onto blank table cells. Also, navigating a table with the control+alt+arrow keys and landing on blank cells would sometimes announce leaving the table.
This was caused by the fact that when expanding a IUIAutomationTextRange in a blank table cell to any text unit, the range will cover the end-of-cell marker, and therefore span more than the cell itself, thus it looks like the range is not entirely inside the cell.

Description of how this pull request fixes the issue:
Work around this MS Word bug by detecting when in this situation: the range is not collapsed, yet the text in the range is either empty or the end-of-cell marker. And if so, Use a copy of the range, that is collapsed to the start (entirely inside the cell) to fetch the text and fields.
This pr also makes a change to Braille, so that when building a line of rich text in braille, a TextInfo's getTextWithFields method is only called if the textInfo is not collapsed. this stops repeating of fields for collapsed ranges, which was sometimes seen in Microsoft Word with UIA enabled.

Fixes #11043
Fixes #11457
Fixes #12490
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/microsoft-office component/UIA-ms-office Specific to UIA used in MS office applications.
Projects
[Project] UIA in Word
  
Done
Milestone
2021.3
Development

Successfully merging a pull request may close this issue.

Correctly read blank cells in MS Word with NVDA's UIA for MS Word option enabled nvaccess/nvda
4 participants
@feerrenrut @fisher729 @nvaccessAuto @brunoprietog