Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unselected is not announced properly in gesture filter field #11326

Open
CyrilleB79 opened this issue Jul 2, 2020 · 4 comments
Open

Unselected is not announced properly in gesture filter field #11326

CyrilleB79 opened this issue Jul 2, 2020 · 4 comments

Comments

@CyrilleB79
Copy link
Collaborator

Steps to reproduce:

  • Open gesture dialog
  • In the filter field, type something, e.g. "braille"
  • Press control+home and then Delete to delete the content of the filter field
  • Type slowly "enable" (with English NVDA UI)

Actual behavior:

Strangely "selection removed" message is heard when typing the "b" letter.

Expected behavior:

Selection removed should be heard when typing the Delete key.

System configuration

NVDA installed/portable/running from source:

From source

NVDA version:

alpha (commit 7023085 )

Windows version:

Windows 10 (2004)

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Yes. 2020.2beta2 works correctly.

If addons are disabled, is your problem still occuring?

Yes

Did you try to run the COM registry fixing tool in NVDA menu / tools?

No

Note

This issue appears in the master branch after #10307 was merged. It was known at the time of this merge. But it was decided to merge anyway since the present issue is relatively minor and to open a new Github issue. See #10307 (comment).

@CyrilleB79
Copy link
Collaborator Author

Cc @JulienCochuyt.

@JulienCochuyt
Copy link
Collaborator

I can reproduce mostly when typing the third letter after deletion, but also sometimes after the second and rarely after the first.
What bothers me the most here is that until the selection removal announce, braille is not updated either.
Still, all review commands report the correct content.

After adding a ton of log traces, I can confirm that IAccessible.event_valueChange is not called at all after the deletion and the first few following keystrokes.

Adding a small delay upon resetting the filter seems to solve the issue.
I don't feel this is much technically satisfying, though.
Upcoming PR.

@lukaszgo1
Copy link
Contributor

It seems #11437 fixes this.

@CyrilleB79
Copy link
Collaborator Author

CyrilleB79 commented Oct 7, 2020

For reference, I am copying here other tests done from #11327.

STR:

  • type "hello" in the filter field (without quotation marks)
  • with the mouse select the word hello
  • type "activatedX" (without quotation marks)
    Result: the selection removal is reported only when the letter "X" is typed. I have also tried the same STR typing NVDA+F2 before each letter of "activatedX" and the result is the same.

and

Moreover, if you type "qw" instead of "activatedX" the selection removal is announced as soon as you type the 2nd character (instead of the 10th for "activatedX"). It seems to me that this issue is directly linked to the filter functionality since the number of character that may be typed before the selection removal is reported seems to depend on the number of output results of the filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants