Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the UAC is cancelled, the COM Reg Fixing Tool still claims to have completed successfully, though an error is logged #12345

Open
XLTechie opened this issue Apr 27, 2021 · 0 comments · May be fixed by #12355
Open

If the UAC is cancelled, the COM Reg Fixing Tool still claims to have completed successfully, though an error is logged #12345

XLTechie opened this issue Apr 27, 2021 · 0 comments · May be fixed by #12355

Comments

@XLTechie
Copy link
Collaborator

Steps to reproduce:

  1. Run the COM Reg Fixing Tool.
  2. Select yes in the initial dialog.
  3. Press escape, or decline the UAC permission request.

Actual behavior:

NVDA logs an error stating that the process was cancelled, but the user gets the same completion dialog as if the run had been successful.

Expected behavior:

Either some other message is shown; or no dialog is shown at all, as if the user had selected no in the initial dialog.

System configuration

NVDA installed/portable/running from source:

Installed and portable

NVDA version:

alpha-22498,d9afe35d

Windows version:

10

Name and version of other software in use when reproducing the issue:

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Same in alpha-22516,a0089a2f

If add-ons are disabled, is your problem still occurring?

yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

yes
@XLTechie XLTechie mentioned this issue Apr 28, 2021
Closed
7 tasks
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Apr 30, 2021
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
24c4f47 
gui.onRunCOMRegistrationFixesCommand:
No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
(Catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.)
If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
Switched from using YES and NO buttons, to YES_NO.
Added a CANCEL button for visual closure and escape key use.
Added a help button to take users to the tool's user manual section (uses gui.contextHelp.showHelp, but not real context help).
Added a docstring and fully linted code. Added more debug logging.
@XLTechie XLTechie linked a pull request Apr 30, 2021 that will close this issue
Draft
7 tasks
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Apr 30, 2021
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
17bedca 
gui.onRunCOMRegistrationFixesCommand:
No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
(Catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.)
If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
Switched from using YES and NO buttons, to YES_NO.
Added a CANCEL button for visual closure and escape key use.
Added a help button to take users to the tool's user manual section (uses gui.contextHelp.showHelp, but not real context help).
Added a docstring and fully linted code. Added more debug logging.
XLTechie added a commit to XLTechie/xlnvda that referenced this issue May 9, 2021
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
c8c1ed5 
gui.onRunCOMRegistrationFixesCommand:
No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
(Catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.)
If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
Switched from using YES and NO buttons, to YES_NO.
Added a CANCEL button for visual closure and escape key use.
Added a help button to take users to the tool's user manual section (uses gui.contextHelp.showHelp, but not real context help).
Added a docstring and fully linted code. Added more debug logging.
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Jun 17, 2021
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
d7fa826 
gui.onRunCOMRegistrationFixesCommand:
No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
(Catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.)
If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
Switched from using YES and NO buttons, to YES_NO.
Added a CANCEL button for visual closure and escape key use.
Added a help button to take users to the tool's user manual section (uses gui.contextHelp.showHelp, but not real context help).
Added a docstring and fully linted code. Added more debug logging.
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Sep 27, 2023
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
cb0466e 
gui.onRunCOMRegistrationFixesCommand:
- No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
- We now catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.
- If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
- Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
- Switched from using YES and NO buttons, to Continue and Cancel (CANCEL button provides visual closure and escape key use).
- Added a docstring and fully linted code. Added more debug logging.
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Dec 15, 2023
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
26b070c 
gui.onRunCOMRegistrationFixesCommand:
- No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
- We now catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.
- If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
- Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
- Switched from using YES and NO buttons, to Continue and Cancel (CANCEL button provides visual closure and escape key use).
- Added a docstring and fully linted code. Added more debug logging.
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Feb 24, 2024
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
1789fc9 
gui.onRunCOMRegistrationFixesCommand:
- No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
- We now catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.
- If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
- Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
- Switched from using YES and NO buttons, to Continue and Cancel (CANCEL button provides visual closure and escape key use).
- Added a docstring and fully linted code. Added more debug logging.
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Feb 24, 2024
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
2cdb2fe 
gui.onRunCOMRegistrationFixesCommand:
- No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
- We now catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.
- If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
- Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
- Switched from using YES and NO buttons, to Continue and Cancel (CANCEL button provides visual closure and escape key use).
- Added a docstring and fully linted code. Added more debug logging.
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Feb 26, 2024
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
c145f18 
gui.onRunCOMRegistrationFixesCommand:
- No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
- We now catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.
- If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
- Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
- Switched from using YES and NO buttons, to Continue and Cancel (CANCEL button provides visual closure and escape key use).
- Added a docstring and fully linted code. Added more debug logging.
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Feb 27, 2024
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
434cc42 
gui.onRunCOMRegistrationFixesCommand:
- No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
- We now catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.
- If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
- Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
- Switched from using YES and NO buttons, to Continue and Cancel (CANCEL button provides visual closure and escape key use).
- Added a docstring and fully linted code. Added more debug logging.
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Mar 7, 2024
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
12924bb 
gui.onRunCOMRegistrationFixesCommand:
- No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
- We now catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.
- If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
- Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
- Switched from using YES and NO buttons, to Continue and Cancel (CANCEL button provides visual closure and escape key use).
- Added a docstring and fully linted code. Added more debug logging.
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Mar 28, 2024
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
25e838d 
gui.onRunCOMRegistrationFixesCommand:
- No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
- We now catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.
- If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
- Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
- Switched from using YES and NO buttons, to Continue and Cancel (CANCEL button provides visual closure and escape key use).
- Added a docstring and fully linted code. Added more debug logging.
XLTechie added a commit to XLTechie/xlnvda that referenced this issue Apr 11, 2024
@XLTechie
Refactored the COM Registration Fixing Tool to fix bugs and improve UX.
ed97e7f 
gui.onRunCOMRegistrationFixesCommand:
- No longer shows success dialog on failure, or when the UAC is canceled or declined (nvaccess#12345)..
- We now catch the Windows error that signals user cancel of UAC, and return as if "NO" had been initially chosen.
- If there is a Windows error other than cancel of UAC, alert the user and show the error in a dialog.
- Rewrote initial dialog message to be more friendly and helpful, and removed warning icon (nvaccess#12351).
- Switched from using YES and NO buttons, to Continue and Cancel (CANCEL button provides visual closure and escape key use).
- Added a docstring and fully linted code. Added more debug logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@XLTechie