Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent alpha versions crash Notepad++ versions 8.2.x and below #13397

Closed
mltony opened this issue Feb 27, 2022 · 1 comment · Fixed by #13382
Closed

Recent alpha versions crash Notepad++ versions 8.2.x and below #13397

mltony opened this issue Feb 27, 2022 · 1 comment · Fixed by #13382
Milestone

Comments

@mltony
Copy link
Contributor

mltony commented Feb 27, 2022

Steps to reproduce:

  1. Use NVDA alpha version nvda_snapshot_alpha-24771,a1a6598b.exe or above.
  2. Open Notepad++ v8.1.x or v8.2.x 64-bit.
    3.Press up/down a few times.

Actual behavior:

Notepad++ crashes. No error message is printed in NVDA log.

Expected behavior:

Notepad++ should not crash.

System configuration

NVDA installed/portable/running from source:

Portable alpha nvda_snapshot_alpha-24771,a1a6598b.exe

NVDA version:

nvda_snapshot_alpha-24771,a1a6598b.exe

Windows version:

Reproduced on both Windows 10 and 11 64-bit.

Name and version of other software in use when reproducing the issue:

Reproduced using either of these two versions (64-bit in both cases):

Other information about your system:

N/A

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Identified that commit a1a6598 is causing this, therefore cc: @lukaszgo1.

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@josephsl
Copy link
Collaborator

josephsl commented Feb 27, 2022 via email

seanbudd pushed a commit that referenced this issue Feb 28, 2022
Fixes regression caused by #13364
Closes #13397

Summary of the issue:
The version matching to apply the new NP++ 8.3+ behavior was incorrect, as it doesn't work for versions like 8.2.1 and 8.1.9.2.

Description of how this pull request fixes the issue:
Only match against the first character of the minor version.

Testing strategy:
Tested on version 8.1.9.2, 8.2.1, 8.3 and 8.3.1 of NP++
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants