Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more settings ring commands. #13768

Closed
TheQuinbox opened this issue Jun 3, 2022 · 1 comment · Fixed by #16095
Closed

Add more settings ring commands. #13768

TheQuinbox opened this issue Jun 3, 2022 · 1 comment · Fixed by #16095
Labels
enhancement good first issue github features these at https://github.com/nvaccess/nvda/contribute p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. ux
Milestone
2024.2

Comments

@TheQuinbox
Copy link
Contributor

TheQuinbox commented Jun 3, 2022 •
edited by feerrenrut

Is your feature request related to a problem? Please describe.

It isn't necessarily a problem, but would definitely make work more efficient.

Describe the solution you'd like

The following keys to be bound globally:

  1. Control+shift+NVDA+Home - laptop, Control+NVDA+Home - desktop
  2. Control+shift+NVDA+end - laptop, Control+NVDA+end - desktop
  3. Control+NVDA+Shift+page up - laptop, Control+NVDA+page up - desktop
    • change value by 10, match GUI behavior
  4. Control+NVDA+shift+page down - laptop, Control+NVDA+shift+page down - desktop
    • change value by 10, match GUI behavior

Note that shift would be removed in desktop layout, because this would apply to the synth settings ring as a hole.

These keys would adjust values by multiple values, or jump to the beginning/end, just like you can do in the actual dialog.

Describe alternatives you've considered

None, other than keeping it the way it is.

Additional context

None.
@seanbudd seanbudd added enhancement p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority ux triaged Has been triaged, issue is waiting for implementation. good first issue github features these at https://github.com/nvaccess/nvda/contribute labels Jun 9, 2022
@rmcpantoja rmcpantoja mentioned this issue Jan 25, 2024
Merged
5 tasks
@rmcpantoja
Copy link
Contributor

I'm glad I'm not the only one who thought of these new commands, since at first I thought it was so I had the idea to do this, but I didn't know this issue existed or that there were people who supported this until I filled out the template for PR #16095. I'm about to do some more tests. It's still WIP.

seanbudd pushed a commit that referenced this issue Feb 11, 2024
@rmcpantoja
Add new commands for synth ring (#16095)
b03f7cb 
Fixes #13768
It's very related to this issue, since it adds these same suggested commands in it for easier navigation in certain cases.

Summary of the issue:
More efficient navigation in the synth settings ring by adding new commands for it.

Description of user facing changes
Added scripts:

CTRL+shift+NVDA+home (laptop) and CTRL+NVDA+home (desktop) to set the current value to the first one.
CTRL+shift+NVDA+page up (laptop) and CTRL+NVDA+page up (desktop) to jump forward the current value by 4x.
CTRL+shift+NVDA+page down (laptop) and CTRL+NVDA+page down (desktop) to jump backward the current value by 4x.
CTRL+shift+NVDA+end (laptop) and CTRL+NVDA+end (desktop) to set the current value to the last one.
Description of development approach
In the synth ring, the first and last functions, as increase or decrease by 4x defs as well, (which handles self.min and self.max) were added to both the numeric ring and the global ring, in their respective classes. I consider this approach to be better, because by jumping in this way, focusing on the minimum and maximum values, it can respect the settings of other synth drivers and thus not cause problems with them.
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Feb 11, 2024
Nael-Sayegh pushed a commit to Nael-Sayegh/nvda that referenced this issue Feb 15, 2024
@rmcpantoja @Nael-Sayegh
Add new commands for synth ring (nvaccess#16095)
676d311 
Fixes nvaccess#13768
It's very related to this issue, since it adds these same suggested commands in it for easier navigation in certain cases.

Summary of the issue:
More efficient navigation in the synth settings ring by adding new commands for it.

Description of user facing changes
Added scripts:

CTRL+shift+NVDA+home (laptop) and CTRL+NVDA+home (desktop) to set the current value to the first one.
CTRL+shift+NVDA+page up (laptop) and CTRL+NVDA+page up (desktop) to jump forward the current value by 4x.
CTRL+shift+NVDA+page down (laptop) and CTRL+NVDA+page down (desktop) to jump backward the current value by 4x.
CTRL+shift+NVDA+end (laptop) and CTRL+NVDA+end (desktop) to set the current value to the last one.
Description of development approach
In the synth ring, the first and last functions, as increase or decrease by 4x defs as well, (which handles self.min and self.max) were added to both the numeric ring and the global ring, in their respective classes. I consider this approach to be better, because by jumping in this way, focusing on the minimum and maximum values, it can respect the settings of other synth drivers and thus not cause problems with them.
Adriani90 pushed a commit to Adriani90/nvda that referenced this issue Mar 13, 2024
@rmcpantoja @Adriani90
Add new commands for synth ring (nvaccess#16095)
a8ada07 
Fixes nvaccess#13768
It's very related to this issue, since it adds these same suggested commands in it for easier navigation in certain cases.

Summary of the issue:
More efficient navigation in the synth settings ring by adding new commands for it.

Description of user facing changes
Added scripts:

CTRL+shift+NVDA+home (laptop) and CTRL+NVDA+home (desktop) to set the current value to the first one.
CTRL+shift+NVDA+page up (laptop) and CTRL+NVDA+page up (desktop) to jump forward the current value by 4x.
CTRL+shift+NVDA+page down (laptop) and CTRL+NVDA+page down (desktop) to jump backward the current value by 4x.
CTRL+shift+NVDA+end (laptop) and CTRL+NVDA+end (desktop) to set the current value to the last one.
Description of development approach
In the synth ring, the first and last functions, as increase or decrease by 4x defs as well, (which handles self.min and self.max) were added to both the numeric ring and the global ring, in their respective classes. I consider this approach to be better, because by jumping in this way, focusing on the minimum and maximum values, it can respect the settings of other synth drivers and thus not cause problems with them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue github features these at https://github.com/nvaccess/nvda/contribute p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. ux
Projects
None yet
Milestone
2024.2
Development

Successfully merging a pull request may close this issue.

Add new commands for synth ring rmcpantoja/nvda
4 participants
@seanbudd @nvaccessAuto @rmcpantoja @TheQuinbox