Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pronunciation for raw Unicode braille cells #13778

Closed
saizai opened this issue Jun 8, 2022 · 0 comments · Fixed by #14548
Closed

add pronunciation for raw Unicode braille cells #13778

saizai opened this issue Jun 8, 2022 · 0 comments · Fixed by #14548
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@saizai
Copy link

saizai commented Jun 8, 2022

If Unicode braille occurs within text — for instance, ⠐⠣⠃⠗⠇⠐⠜ says "(braille)" in UEB — NVDA currently just skips over the braille entirely. It should at least pronounce the braille cells.

Because this is pronunciation for the Unicode characters themselves, it should be braille-code-agnostic and just pronounce individual braille characters in the usual "dot 3 5 7" way.

I've made a pull request that does this: #13777

Separately — my pull request does not address this — NVDA should be able to interpret Unicode braille that's embedded in non-braille text based on its current input/output code table settings, and just bracket that by some sort of indicator. E.g. if the output is UEB2 braille, use ⠐⠷⠑⠝⠤⠥⠑⠃⠼⠃⠄… ⠠⠐⠾ to indicate a Unicode-braille UEB grade 2 passage within auto-translated text, or ⠐⠷⠃⠗⠇⠄… ⠠⠐⠾ to indicate Unicode braille of unknown code; if the output is English speech, have the narrator speak "begin Unicode braille" and "end Unicode braille" to bracket it.

So e.g.:

  • text being presented: for instance, ⠐⠣⠃⠗⠇⠐⠜ says "(braille)" in UEB
  • UEB2 braille display output (modify as appropriate for other output codes): ⠿⠀⠔⠌⠨⠑⠂⠀⠐⠷⠃⠗⠇⠠⠀⠐⠣⠃⠗⠇⠐⠜⠀⠠⠐⠾⠀⠎⠁⠽⠎⠀⠦⠐⠣⠃⠖⠇⠐⠜⠴⠀⠔⠀⠠⠠⠥⠑⠃
    • Current NVDA UEB2 output: ⠿⠀⠔⠌⠨⠑⠂⠀⠐⠣⠃⠗⠇⠐⠜⠀⠎⠁⠽⠎⠀⠦⠐⠣⠃⠖⠇⠐⠜⠴⠀⠔⠀⠠⠠⠥⠑⠃. This doesn't indicate the switch between NVDA-converted text and literal braille.
  • English speech output (again, modify as appropriate for the quote and the localised way to speak a braille cell): for instance, begin Unicode braille, dot 5 dot 1 2 6 dot 1 2 dot 1 2 3 5 dot 1 2 3 dot 5 dot 3 4 5, end Unicode braille, says quote left paren braille right paren quote in cap u e b
    • better speech output: for instance, begin Unicode braille, dots 5, 1 2 6, 1 2, 1 2 3 5, 1 2 3, 5, 3 4 5, end Unicode braille, says quote left paren braille right paren quote in cap u e b.
    • current NVDA English output (in my config): for instance comma says left paren, braille, right paren, in u e b. This totally omits the Unicode braille, and doesn't even indicate that anything is there.

The better version would require some sort of mode flag in the pronunciation code to indicate that 'dot' doesn't need to be repeated in contiguous Unicode braille. I don't know how to do that in NVDA, and have not attempted to do so here. This PR does at least the minimum possible thing to make Unicode braille audible at all, which is an improvement over the current status.

I would also suggest that if NVDA encounters something it doesn't know how to pronounce, its speech output should at the very least give some indication that something was there, like with a special beep. (This is as opposed to encountering punctuation it knows how to pronounce and is set to ignore, like the quote marks and all-caps in the above under my config. I did not tell it to ignore the character ⠿, but if I rely on my speech output, it's completely invisible.)

@seanbudd seanbudd added the triaged Has been triaged, issue is waiting for implementation. label Jun 9, 2022
@michaelDCurran michaelDCurran added the p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Sep 12, 2022
seanbudd added a commit that referenced this issue Feb 14, 2023
Fixes #13778
Supersedes #13777

Summary of the issue:
If Unicode braille occurs within text — for instance, ⠐⠣⠃⠗⠇⠐⠜ says "(braille)" in UEB — NVDA currently just skips over the braille entirely. This is because it is not included in symbols.dic

Description of user facing changes
Unicode braille symbols are now announced.
@nvaccessAuto nvaccessAuto modified the milestone: 2023.2 Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants