Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send dashes to the synthesizer by default #13830

Closed
tspivey opened this issue Jun 22, 2022 · 4 comments · Fixed by #13857
Closed

Send dashes to the synthesizer by default #13830

tspivey opened this issue Jun 22, 2022 · 4 comments · Fixed by #13857
Labels
good first issue github features these at https://github.com/nvaccess/nvda/contribute p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority quick fix triaged Has been triaged, issue is waiting for implementation. z goodfirstissue (archived) z goodForNewDev (archived)
Milestone

Comments

@tspivey
Copy link
Collaborator

tspivey commented Jun 22, 2022

Steps to reproduce:

  1. Set NVDA to use OneCore and one of the English voices. Mark will work.
  2. You'll need to reset your punctuation/symbols to defaults, unless you know you haven't modified the -. There's no way to do this from the GUI, so back up or delete symbols_en.dic manually.
  3. Set symbol level to some.
  4. Read the following: Jean-Luc Picard, 1950-1960
  5. Change Preserve of - to always and read them again.

Actual behavior:

I hear Jean Luc Picard, and 1950 1960

Expected behavior:

The synthesizer knows what it's doing here, so I want to hear these pronounced correctly.
This should also apply to —. – is set to always by default, so should be fine.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2022.1

Windows version:

Windows 10 X64 Version 21H1 (OS Build 19043.1766)

Name and version of other software in use when reproducing the issue:

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

No

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@CyrilleB79
Copy link
Collaborator

Hi @tspivey

The example "Jean-Luc Picard" seems to be pronounced correctly to me.
You have taken the "New feature" template, but you are actually describing an incorrect behaviour of the existing symbol reporting feature. Would you mind use the bug report template instead and fill it adequately?

And describe:

  • The symbol level used
  • What you actually hear
  • What you want to hear

Thanks.

@tspivey
Copy link
Collaborator Author

tspivey commented Jun 22, 2022

Description updated. Personally I use only below symbol's level, but I used always for consistency with the rest of the punctuation (parentheses, …, etc).

@TheQuinbox
Copy link
Contributor

Only issue with this is that it breaks when reading certain code blocks. For example:

x := 5
x -= 2

When having dashes passed to the synthesizer, these two lines sound almost the exact same, in terms of the pauses.

@tspivey
Copy link
Collaborator Author

tspivey commented Jun 24, 2022

Programmers have enough knowledge to adjust their punctuation exactly the way they want, and NVDA gives them the tools to do so. I just want better defaults.

@seanbudd seanbudd added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Jun 30, 2022
@feerrenrut feerrenrut added z goodForNewDev (archived) quick fix z goodfirstissue (archived) good first issue github features these at https://github.com/nvaccess/nvda/contribute labels Jun 30, 2022
seanbudd added a commit that referenced this issue Feb 14, 2023
Closes #13830

Summary of the issue:
In #13830, changing the "send to synthesizer" to "always" is suggested for dashes.
Dash and em-dash are proposed here.

Description of user facing changes
Changes defaults for synthesizer pronunciation

Description of development approach
Update symbols.dic

Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue github features these at https://github.com/nvaccess/nvda/contribute p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority quick fix triaged Has been triaged, issue is waiting for implementation. z goodfirstissue (archived) z goodForNewDev (archived)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants