Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows versions: let NVDA recognize Windows 10/11 Version 22H2 #13845

Closed
josephsl opened this issue Jun 27, 2022 · 0 comments · Fixed by #13963
Closed

Windows versions: let NVDA recognize Windows 10/11 Version 22H2 #13845

josephsl opened this issue Jun 27, 2022 · 0 comments · Fixed by #13963
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2022.4

Comments

@josephsl
Copy link
Collaborator

Background:

As of November 2021, Microsoft has moved to annual update cycle for Windows 10 and 11. This means there is no YYH1 updates, making it a bit easier to predict what the next version of Windows 10 and 11 will be. This also incresaes uncertainty somewhat as feature update builds can be a bit unpredictable:

  • Windows 10: Windows 10 is in maintenance mode (Vibranium releases). While people can guess what the build number can be (see below), we don't know when the final feature update will be released (I'm guessing 2023 based on support lifecycle for Home/Pro versus Enterprise/Education).
  • Windows 11: build prediction is unpredictable as Microsoft can sign off on a build some time in northern spring with refresh branches used to prepare cumulative updates for the base build (compare co_release vs. co_refresh branches from last year).

Is your feature request related to a problem? Please describe.

With the impending release of Windows 10 and 11 Version 22H2, let NVDA recognize 22H2 builds. This can aid in detecting Sun Valley 2 (SV2) builds for UIA console and other work.

Describe the solution you'd like

Recognize the following builds:

  • Windows 10 Version 22H2: 19045
  • Windows 11 Version 22H2 (nickel/SV2): 22621

In addition, update AppX manifest to state that the last tested version is 10.0.22621.0 and ask folks to use Windows 11 SDK build 22621 (now available).

Describe alternatives you've considered

Leave things as is.

Additional context

Typically, new Windows builds are recognized once builds move to release preview channel. For Windows 11, this took place on June 7, 2022, and for Windows 10, it is being worked on internally.

Pull request strategy:

Choose from one of the following paths assuming that a PR is created:

  1. Merge the upcoming PR.
  2. Wait until Windows 10 Version 22H2 is released to release preview Insiders before merging the upcoming PR.

Thanks.
@seanbudd seanbudd added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Jun 28, 2022
josephsl added a commit to josephsl/nvda that referenced this issue Jul 3, 2022
@josephsl
winVersion: recognize build 22621 as Windows 11 22H2 (Sun Valley 2/ni…
33d510a 
…ckel). re nvaccess#13845
josephsl added a commit to josephsl/nvda that referenced this issue Jul 3, 2022
@josephsl
AppX manifest: max version tested -> 10.0.22621.0. Re nvaccess#13845
73b063b
josephsl added a commit to josephsl/nvda that referenced this issue Jul 3, 2022
@josephsl
Readme: Windows 11 SDK 10.0.22000 -> 10.0.22621. Re nvaccess#13845
eb46dca
josephsl added a commit to josephsl/nvda that referenced this issue Jul 3, 2022
@josephsl
winVersion: recognize build 19045 as Windows 11 22H2 (Vibranium). Re n…
fc23a3d 
…vaccess#13845
@josephsl josephsl mentioned this issue Jul 3, 2022
Merged
5 tasks
josephsl added a commit to josephsl/nvda that referenced this issue Jul 3, 2022
@josephsl
winVersion: recognize build 19045 as Windows 10 22H2 (Vibranium). Re n…
13237bb 
…vaccess#13845
josephsl added a commit to josephsl/nvda that referenced this issue Jul 28, 2022
@josephsl
Revert "Readme: Windows 11 SDK 10.0.22000 -> 10.0.22621. Re nvaccess#…
2470d15 
…13845"

This reverts commit eb46dca. Even though Appveyor did install Windows 11 SDK 10.0.22621, it aplies to Visual Studio 2022 image (July 2022).
josephsl added a commit to josephsl/nvda that referenced this issue Jul 28, 2022
@josephsl
Revert "winVersion: recognize build 19045 as Windows 10 22H2 (Vibrani…
bf1ee18 
…um). Re nvaccess#13845"

This reverts commit 13237bb, deferred to a future pull request as Windows 10 Version 22H2 was not relased to Windows Insiders as of July 2022.
josephsl added a commit to josephsl/nvda that referenced this issue Jul 28, 2022
@josephsl
winVersion: recognize build 19045 as Windows 10 22H2 (Vibranium). Re n…
1931518 
…vaccess#13845
@josephsl josephsl mentioned this issue Jul 28, 2022
Merged
5 tasks
seanbudd pushed a commit that referenced this issue Jul 29, 2022
@josephsl
winVersion: recognize build 19045 as Windows 10 22H2 (Vibranium) (#13963
460aec3 
)

Partially closes #13845
Windows 10 part of #13867

Summary of the issue:
Recognize Windows 10 build 19045 as Version 22H2.

Description of user facing changes
None

Description of development approach
Tested through Windows Insider Program - added Windows 10 build 19045 metadata.

Testing strategy:
Manual testing: instal Windows 10 build 19045 release preview build to make sure it is recognized as 22H2 by NVDA.
@nvaccessAuto nvaccessAuto modified the milestone: 2022.4 Jul 29, 2022
josephsl added a commit to josephsl/nvda that referenced this issue Jul 29, 2022
@josephsl
winVersion: recognize build 22621 as Windows 11 22H2 (Sun Valley 2/ni…
945fe27 
…ckel). re nvaccess#13845
josephsl added a commit to josephsl/nvda that referenced this issue Jul 29, 2022
@josephsl
AppX manifest: max version tested -> 10.0.22621.0. Re nvaccess#13845
bf3ab90
josephsl added a commit to josephsl/nvda that referenced this issue Aug 13, 2022
@josephsl
winVersion: recognize build 22621 as Windows 11 22H2 (Sun Valley 2/ni…
9315b49 
…ckel). re nvaccess#13845
josephsl added a commit to josephsl/nvda that referenced this issue Aug 13, 2022
@josephsl
AppX manifest: max version tested -> 10.0.22621.0. Re nvaccess#13845
bf4e281
seanbudd pushed a commit that referenced this issue Aug 15, 2022
@josephsl
Windows versions: recognize build 22621 as Windows 11 22H2 (#13867)
d00f886 
Closes parts of #13845

Summary of the issue:
Recognize Windows 22H2 releases. In part 1 (this pull request), recognize 10.0.22621 as Windows 11 Version 22H2 (Nickel/Sun Valley 2).

Description of user facing changes
No user facing changes

Description of development approach
Verified that the following builds will be tied to upcoming Windows feature updates:

19045: Windows 10 22H2 (see additional context as this is out of scope for this PR)
22621: Windows 11 22H2
Build 22621 is available to release preview Windows Insiders, build 19045 forthcoming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2022.4
Development

Successfully merging a pull request may close this issue.

winVersion: recognize build 19045 as Windows 10 22H2 (Vibranium). Re #13845 josephsl/nvda
3 participants
@seanbudd @josephsl @nvaccessAuto