Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to configure figure and caption reporting #14349

Closed
kara-louise opened this issue Nov 8, 2022 · 6 comments · Fixed by #16176
Closed

Add option to configure figure and caption reporting #14349

kara-louise opened this issue Nov 8, 2022 · 6 comments · Fixed by #16176
Labels
app/firefox blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. feature/browse-mode feature needs-triage p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone
2024.2

Comments

@kara-louise
Copy link

kara-louise commented Nov 8, 2022 •
edited by feerrenrut

Is your feature request related to a problem? Please describe.

Currently, there is no way to configure reporting of figure or caption elements when using browse mode.

Describe the solution you'd like

Either have one checkbox that would toggle both figures and captions together, or a separate one for each.

Describe alternatives you've considered

Additional context

Sample source view

  • Using Firefox visit: Full view
  • Move the virtual cursor to "button before" in browse mode.
  • Press down arrow:
NVDA+space
Browse mode
NVDA+up arrow
button    before
down arrow
figure    caption    Media caption XYZ
@seanbudd seanbudd added feature/browse-mode p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority feature labels Nov 15, 2022
@feerrenrut

This comment was marked as resolved.

Sign in to view
@seanbudd seanbudd added the blocked/needs-info The issue can not be progressed until more information is provided. label Nov 15, 2022
@kara-louise

This comment was marked as resolved.

Sign in to view
@feerrenrut

This comment was marked as resolved.

Sign in to view
@feerrenrut feerrenrut changed the title Add options to toggle reporting of figures and captions Add option to configure figure and caption reporting Nov 18, 2022
@feerrenrut feerrenrut added blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. app/firefox and removed blocked/needs-info The issue can not be progressed until more information is provided. labels Nov 18, 2022
@seanbudd seanbudd mentioned this issue Sep 25, 2023
Closed
@Adriani90
Copy link
Collaborator

The "figure" part of this issue is a duplicate of #10826.

@SaschaCowley SaschaCowley mentioned this issue Feb 14, 2024
Merged
5 tasks
@nvaccessAuto nvaccessAuto modified the milestone: 2024.2 Feb 22, 2024
@Adriani90
Copy link
Collaborator

Reopening since #16176 does include figures, but not captions. So captions need to be added as well.

@Adriani90 Adriani90 reopened this Feb 23, 2024
@Adriani90
Copy link
Collaborator

Closing as stated in #10826.

Adriani90 pushed a commit to Adriani90/nvda that referenced this issue Mar 13, 2024
@SaschaCowley @Adriani90
Make figure reporting configureable, and figures quick navigable (nva…
f723272 
…ccess#16176)

fixes nvaccess#10826
Fixes nvaccess#14349

Summary of the issue:
It has hitherto not been possible to navigate by figure with quick navigation keys, or to disable the reporting of figures and captions.

Description of user facing changes
Added a script to jump to next/previous figure in browse mode. Added an option to disable the reporting of figures and captions, and a script to toggle this setting.

Description of development approach
Examined similar code and based new code on existing code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/firefox blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. feature/browse-mode feature needs-triage p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Milestone
2024.2
Development

Successfully merging a pull request may close this issue.

Make figure reporting configureable, and figures quick navigable SaschaCowley/nvda
5 participants
@feerrenrut @seanbudd @nvaccessAuto @kara-louise @Adriani90