Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accurate to the second when using NVDA+f12 to get the time. #14742

Closed
cary-rowen opened this issue Mar 25, 2023 · 4 comments · Fixed by #14792
Closed

Accurate to the second when using NVDA+f12 to get the time. #14742

cary-rowen opened this issue Mar 25, 2023 · 4 comments · Fixed by #14792
Labels
enhancement feature p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2023.2

Comments

@cary-rowen
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In some online shopping malls merchants often have limited-time promotions, For example, "3 minutes and 59 seconds left" to start flash sale.
It might help if the visually impaired could get the seconds of the current time in a more accurate way.

Describe the solution you'd like

Accurate to the second when using NVDA+f12 to get the time.

Describe alternatives you've considered

None

Additional context

If, this is acceptable, I will open a PR to implement the feature request.
@CyrilleB79
Copy link
Collaborator

As a workaround and a solution in the meantime, there is already an add-on (Clock) for this. The add-on contains much more features though.

@cary-rowen
Copy link
Contributor Author

Thanks @CyrilleB79
I've used this add-on and it's great.
I wonder if there is any special consideration for NVDA not including the seconds when reporting the current time?

@seanbudd seanbudd added enhancement p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority feature triaged Has been triaged, issue is waiting for implementation. labels Mar 29, 2023
@michaelDCurran
Copy link
Member

I'm not sure how add-ons are presenting this so far, but I would accept something like 9:44 am and 50 seconds. But not where the seconds were before the am. As we don't want to affect the current behaviour.

@cary-rowen
Copy link
Contributor Author

@michaelDCurran
According to my observation, the current internal implementation of NVDA+F12 uses winKernel.GetTimeFormatEx.
text=winKernel.GetTimeFormatEx(winKernel.LOCALE_NAME_USER_DEFAULT, winKernel.TIME_NOSECONDS, None, None)
If we want to implement this feature, just set the second parameter in the above function to None.
Therefore, the final output content depends on the system settings, also, it doesn't break the existing user experience.

@cary-rowen cary-rowen mentioned this issue Apr 5, 2023
Merged
6 tasks
seanbudd pushed a commit that referenced this issue Jun 1, 2023
@cary-rowen
Make NVDA accurate to the second when reporting time (#14792)
8edfbbf 
Closes #14742

Summary of the issue:
Currently, NVDA+F12 does not include seconds when reporting time.
In some online shopping malls merchants often have limited-time promotions, For example, "3 minutes and 59 seconds left" to start flash sale.
It might help if the visually impaired could get the seconds of the current time in a more accurate way.

Description of user facing changes
NVDA does not control the format of the reported time, it is determined by the user's system settings, specifically, NVDA will refer to the 'Long time' option in the system settings.

In the latest Windows 11 operating system, Microsoft allows users to choose whether to display seconds on the system clock.
For Windows 10 and older operating systems, users can choose whether to display seconds on the system clock by changing the registry.
If the user has allowed seconds to be displayed on the system clock, then NVDA +F12 will also include the seconds.
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2023.2
Development

Successfully merging a pull request may close this issue.

Make NVDA accurate to the second when reporting time cary-rowen/nvda
5 participants
@seanbudd @michaelDCurran @nvaccessAuto @CyrilleB79 @cary-rowen